From patchwork Thu Feb 14 12:21:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2141521 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 46A243FCF6 for ; Thu, 14 Feb 2013 12:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934236Ab3BNMVX (ORCPT ); Thu, 14 Feb 2013 07:21:23 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:63048 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758549Ab3BNMVW convert rfc822-to-8bit (ORCPT ); Thu, 14 Feb 2013 07:21:22 -0500 Received: from klappe2.localnet (HSI-KBW-46-223-90-92.hsi.kabel-badenwuerttemberg.de [46.223.90.92]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0Lmufk-1UXJL91WCy-00h2ab; Thu, 14 Feb 2013 13:21:19 +0100 From: Arnd Bergmann To: Ezequiel Garcia Subject: Re: Build error: OMAP randconfig / mvebu Date: Thu, 14 Feb 2013 12:21:16 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-5-generic; KDE/4.3.2; x86_64; ; ) Cc: "Russell King - ARM Linux" , Andrew Lunn , Jason Cooper , arm@kernel.org, Gregory CLEMENT , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20130208100813.GN17833@n2100.arm.linux.org.uk> <201302141127.07378.arnd@arndb.de> <20130214120650.GA11345@localhost> In-Reply-To: <20130214120650.GA11345@localhost> MIME-Version: 1.0 Message-Id: <201302141221.16267.arnd@arndb.de> X-Provags-ID: V02:K0:EF+gN5Hc7hHEKmtAe11r/Xf1/9WkHiHVjcy1pkSX9me b1j9tYUKYNpiqUbzfnbwNr9F0+U8bnObTr0QKiwye2KAnpNX+v K6Jysyyn5I6+LZ3zhuPNlD9TdVhNEa0ANVpzdUZXIoFMkkogG7 hgWh/pd2rE1RgORIsWwRk7+yKch7rM0WRwiTNZYTEzl6waT4Su pfv1oEFJJTSdOd7VRMeehTVmXgIp2ub+3ZAjswgBc/YfXSE7UZ K4c0LH2eqd7x57Q8VavpfgZ27fNYB0bpJzd1j8xfdo2B8KhFmh cOdUaqCWHSHi+zVRiUunxrkXtUiyWr5xE+Atf8qhOff+1DBrwy scixZQQ0wVRrRVpCpQq4= Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thursday 14 February 2013, Ezequiel Garcia wrote: > Now, using the random config there's a new error, unrelated to the > previous one: > > ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined! > ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined! > ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined! > ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined! Yes, I guess that is an unrelated error. However, my patch also wasn't correct because it is not allowed to have an empty list of objects. There is an updated patch below, I could add that straight to the branch that caused the problem if it looks ok to you. Arnd ---- From 0860b5b4558ad777068826bc9a735b82f3cf0d88 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Thu, 14 Feb 2013 13:14:53 +0100 Subject: [PATCH] ARM: mvebu: allow selecting mvebu without Armada XP Selecting only CONFIG_ARCH_MVEBU but not the respective options for Armada 370 or Armada XP results in these link errors: arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus': arch/arm/mach-mvebu/platsmp.c:91: undefined reference to `coherency_get_cpu_count' arch/arm/mach-mvebu/platsmp.c:104: undefined reference to `armada_mpic_send_doorbell' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus': arch/arm/mach-mvebu/platsmp.c:111: undefined reference to `set_cpu_coherent' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary': arch/arm/mach-mvebu/platsmp.c:83: undefined reference to `armada_xp_boot_cpu' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init': arch/arm/mach-mvebu/platsmp.c:75: undefined reference to `armada_xp_mpic_smp_cpu_init' arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup': arch/arm/mach-mvebu/headsmp.S:46: undefined reference to `ll_set_cpu_coherent' We can solve this by enabling all common MVEBU files that are referenced by the SMP files. This means we enable code that is not going to be used without a machine descriptor referencing it, but only if the kernel is configured specifically for this case. Signed-off-by: Arnd Bergmann Cc: Gregory Clement Cc: Ezequiel Garcia Tested-by: Gregory Clement on Armada 370 DB Acked-by: Jason Cooper --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile index 99df4df..da93bcb 100644 --- a/arch/arm/mach-mvebu/Makefile +++ b/arch/arm/mach-mvebu/Makefile @@ -3,7 +3,8 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \ AFLAGS_coherency_ll.o := -Wa,-march=armv7-a -obj-y += system-controller.o -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o +obj-y += system-controller.o +obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o +obj-$(CONFIG_ARCH_MVEBU) += addr-map.o coherency.o coherency_ll.o pmsu.o irq-armada-370-xp.o obj-$(CONFIG_SMP) += platsmp.o headsmp.o obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o