From patchwork Tue Apr 30 11:43:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot for Dave Martin X-Patchwork-Id: 2504241 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 911263FD40 for ; Tue, 30 Apr 2013 11:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760270Ab3D3LnY (ORCPT ); Tue, 30 Apr 2013 07:43:24 -0400 Received: from mail-ee0-f41.google.com ([74.125.83.41]:34065 "EHLO mail-ee0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759520Ab3D3LnY (ORCPT ); Tue, 30 Apr 2013 07:43:24 -0400 Received: by mail-ee0-f41.google.com with SMTP id c50so199388eek.14 for ; Tue, 30 Apr 2013 04:43:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=3P6eeeVMwKN5QT0SZ0MRsy7xpLrfmBpwkS4JIauKvoE=; b=CNEST0rca2gTGMx/XTMzHzfNtcQdC0bb74e5CFFR+fs2YGTKty7m6jSD+rsAIs42tg 3z/Y7+8IcBAs2itA4BLyCIZwrCG4agdCNQtL5t7Lztlh++ZWLlN31EerSlzBIVdTyp7t o3nJ6Lybh7zqW7v2BYq1dFc6x+GyErtNE7w7QkKs8wnytE07EOXPEjN1eqRPVrSttjMj rgJpWieOhtQziWNr3vKcMyVD0YrgtS/WcOxDQnfDV5vEfAYRCMatnvbciJM3dZxuWkI0 Ui3fbpscI1TLizR2MsqwCRJFEt5wVJIRirNYAS0z01ufSRzJ6OvfwZ2LyBv5ErKlwQD6 K0LQ== X-Received: by 10.14.105.1 with SMTP id j1mr89201410eeg.6.1367322202413; Tue, 30 Apr 2013 04:43:22 -0700 (PDT) Received: from linaro.org (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id ch6sm38203517eeb.17.2013.04.30.04.43.19 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 30 Apr 2013 04:43:21 -0700 (PDT) Date: Tue, 30 Apr 2013 12:43:11 +0100 From: Dave Martin To: Arnd Bergmann Cc: Russell King - ARM Linux , Tony Lindgren , Catalin Marinas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Pitre Subject: Re: Latest build results - errors/warnings - lots of them Message-ID: <20130430114229.GA2439@linaro.org> References: <20130430081739.GP14496@n2100.arm.linux.org.uk> <201304301304.20650.arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201304301304.20650.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQm7b2k72fjL0zWavYGzGk/y4TjMKFa818PJHfdP0TPAVx1HdNR+BUzkkNhT6TKzGFvu+qMh Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Tue, Apr 30, 2013 at 01:04:20PM +0200, Arnd Bergmann wrote: > On Tuesday 30 April 2013, Russell King - ARM Linux wrote: > > Latest nightly build of 3.9+my for-next+arm-soc's for-next results in a > > great load of new warnings and errors. arch/arm/common/mcpm_head.S, > > arch/arm/common/mcpm_platsmp.c, arch/arm/common/vlock.S are the biggest > > source of errors. [...] > >arch/arm/common/mcpm_head.S:39: Error: selected processor does not support ARM mode `ubfx r9,r0,#0,#8' > >arch/arm/common/mcpm_head.S:40: Error: selected processor does not support ARM mode `ubfx r10,r0,#8,#8' > >arch/arm/common/mcpm_head.S:100: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:115: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:127: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:131: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:138: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/mcpm_head.S:152: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:161: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:175: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:62: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/vlock.S:89: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/vlock.S:102: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:105: Error: selected processor does not support ARM mode `dsb' > > Right, the problem here is that the code was never tested with an ARMv6+ARMv7 config. > We can either fix it up by adding > > .arch armv7-a > > in the assembly files, or by doing the same in the Makefile: > > AFLAGS_vlock.S += -march=armv7-a > AFLAGS_mcpm_head.S += -march=armv7-a Hmmm, this code was tested with ARCH_MULTIPLATFORM, but it looks like no v6 boards were configured in when testing that... Assuming people are OK with the Makefile route, here's a patch for that, build-tested with a v6+v7 ARCH_MULTIPLATFORM config. Cheers ---Dave From 193f254689beaa1612d29bcc5ba004a933b37d95 Mon Sep 17 00:00:00 2001 From: Dave Martin Date: Tue, 30 Apr 2013 12:25:04 +0100 Subject: [PATCH 1/3] ARM: mcpm: Add explicit AFLAGS to support v6/v7 multiplatform kernels The full mcpm layer is not likely to be relevant to v6 based platforms, so a multiplatform kernel won't use that code if booted on v6 hardware. This patch modifies the AFLAGS for affected mcpm .S files to specify armv7-a explicitly for that code. Signed-off-by: Dave Martin Acked-by: Arnd Bergmann Acked-by: Nicolas Pitre --- arch/arm/common/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/common/Makefile b/arch/arm/common/Makefile index 546a932..d65a0a8 100644 --- a/arch/arm/common/Makefile +++ b/arch/arm/common/Makefile @@ -12,6 +12,8 @@ obj-$(CONFIG_SHARP_SCOOP) += scoop.o obj-$(CONFIG_PCI_HOST_ITE8152) += it8152.o obj-$(CONFIG_ARM_TIMER_SP804) += timer-sp.o obj-$(CONFIG_MCPM) += mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o +AFLAGS_mcpm_head.o := -march=armv7-a +AFLAGS_vlock.o := -march=armv7-a CFLAGS_REMOVE_mcpm_entry.o = -pg obj-$(CONFIG_FIQ_GLUE) += fiq_glue.o fiq_glue_setup.o obj-$(CONFIG_FIQ_DEBUGGER) += fiq_debugger.o