From patchwork Fri Sep 20 18:24:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 2920171 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 731B19F1E2 for ; Fri, 20 Sep 2013 18:25:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7D13D2018B for ; Fri, 20 Sep 2013 18:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 414242026C for ; Fri, 20 Sep 2013 18:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832Ab3ITSY4 (ORCPT ); Fri, 20 Sep 2013 14:24:56 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:39985 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775Ab3ITSYz (ORCPT ); Fri, 20 Sep 2013 14:24:55 -0400 Received: by mail-ee0-f46.google.com with SMTP id c13so443989eek.33 for ; Fri, 20 Sep 2013 11:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=iq48B50MXhXiv5TPX0/HsDS7sKd5DPtzl6v5yjiGOGM=; b=Yr0e5xO551rP/ttxr5knOdHFVxNxmgE6cdzc7OMi4EBzFu2Q0xgpg2R8jrkr4uDq69 e5Sv1vFo73bnNrJsPSMjaLRoasVasHiYNR1tmUZHFRbQdPhgPBg+1+o8/7MZ5zS1v6U+ UhiaICX88qHwifN+IyfAbUxVS3wJzOJoErcs8cjK3GWBaNO7oNftjWA/jhfmnHIfzhTr LRRPrmRU7YphB5WrTd2SIz4rU5xef2jIgocdRoQYL4bR7NM70zZyjATO2bzPtomxpZlN Trph5M6QQVT+bCkm+MMHsAQJXUtkq/h5xaa4V63utf/tiMb630RKwp1sFRaO/olIguJU nyDw== X-Received: by 10.14.172.7 with SMTP id s7mr79681eel.109.1379701493485; Fri, 20 Sep 2013 11:24:53 -0700 (PDT) Received: from pali-elitebook.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id r48sm21319107eev.14.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Sep 2013 11:24:52 -0700 (PDT) From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng Date: Fri, 20 Sep 2013 20:24:50 +0200 User-Agent: KMail/1.13.7 (Linux/3.11.0-1+synaptics-generic; KDE/4.11.1; x86_64; ; ) Cc: Matt Mackall , Herbert Xu , Russell King , Joe Perches , Aaro Koskinen , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org References: <1379534757-20870-1-git-send-email-pali.rohar@gmail.com> <201309201841.16197@pali> <20130920174640.GA2684@atomide.com> In-Reply-To: <20130920174640.GA2684@atomide.com> MIME-Version: 1.0 Message-Id: <201309202024.50755@pali> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, T_TVD_MIME_EPI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 20 September 2013 19:46:41 Tony Lindgren wrote: > * Pali Rohár [130920 09:49]: > > On Friday 20 September 2013 18:23:43 Tony Lindgren wrote: > > > * Pali Rohár [130920 06:33]: > > > > Name omap_rng is already used by omap_rng driver which > > > > is for omap2 and omap4. For omap3 HS devices there is > > > > new driver omap3-rom-rng which needs that clk. And > > > > because there cannot be two drivers with same name, > > > > rename omap3 clk dev id. > > > > > > > > Signed-off-by: Pali Rohár > > > > --- > > > > > > > > arch/arm/mach-omap2/cclock3xxx_data.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c > > > > b/arch/arm/mach-omap2/cclock3xxx_data.c index > > > > 334b767..5059338 100644 > > > > --- a/arch/arm/mach-omap2/cclock3xxx_data.c > > > > +++ b/arch/arm/mach-omap2/cclock3xxx_data.c > > > > @@ -3274,7 +3274,7 @@ static struct omap_clk > > > > omap36xx_clks[] = { > > > > > > > > */ > > > > > > > > static struct omap_clk omap34xx_omap36xx_clks[] = { > > > > > > > > CLK(NULL, "aes1_ick", &aes1_ick), > > > > > > > > - CLK("omap_rng", "ick", &rng_ick), > > > > + CLK("omap3-rom-rng", "ick", &rng_ick), > > > > > > > > CLK(NULL, "sha11_ick", &sha11_ick), > > > > CLK(NULL, "des1_ick", &des1_ick), > > > > CLK(NULL, "cam_mclk", &cam_mclk), > > > > > > Hmm are you sure the omap_rng is not available on > > > any of the omap3 GP versions? If so, the omap_rng > > > alias should be kept as well. > > > > > > Regards, > > > > > > Tony > > > > I really do not know, but driver char/hw_random/omap-rng.c > > support only omap2 and omap4 platforms. So "omap_rng" dev id > > for omap3 is not used. > > > > In email [1] you suggested to use clk_get instead > > clk_get_sys. If I understand correctly clk_get calling > > clk_get_sys with driver name. So dev in in CLK macro must > > be same as driver name. And because in cclock3xxx_data.c is > > dev id "omap_rng" and there is already driver with name > > "omap_rng", I need to rename dev in cclock3xxx_data.c to > > get new omap3-rom-rng driver working. > > > > Or if you know better way how to do it, let me know. > > I think it's safest to keep the existing alias also, and > add a comment saying that it may not be available on omap3 > processors. > > Regards, > > Tony > > > [1] - https://lkml.org/lkml/2013/4/1/278 Ok, then there is new patch which only adding omap3-rom-rng and not removing omap_rng. It is OK to have same CLK data but with different names? diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c index 334b767..03a2829 100644 --- a/arch/arm/mach-omap2/cclock3xxx_data.c +++ b/arch/arm/mach-omap2/cclock3xxx_data.c @@ -3275,6 +3275,7 @@ static struct omap_clk omap36xx_clks[] = { static struct omap_clk omap34xx_omap36xx_clks[] = { CLK(NULL, "aes1_ick", &aes1_ick), CLK("omap_rng", "ick", &rng_ick), + CLK("omap3-rom-rng", "ick", &rng_ick), CLK(NULL, "sha11_ick", &sha11_ick), CLK(NULL, "des1_ick", &des1_ick), CLK(NULL, "cam_mclk", &cam_mclk),