From patchwork Thu Nov 21 05:30:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 3216851 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 159BA9F3A0 for ; Thu, 21 Nov 2013 05:30:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 412C120776 for ; Thu, 21 Nov 2013 05:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24F302075F for ; Thu, 21 Nov 2013 05:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501Ab3KUFaa (ORCPT ); Thu, 21 Nov 2013 00:30:30 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:38107 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724Ab3KUFa3 (ORCPT ); Thu, 21 Nov 2013 00:30:29 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id rAL5U81q000845; Wed, 20 Nov 2013 23:30:08 -0600 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rAL5U7mu022225; Wed, 20 Nov 2013 23:30:08 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Wed, 20 Nov 2013 23:30:06 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rAL5U6Eo005046; Wed, 20 Nov 2013 23:30:06 -0600 Date: Wed, 20 Nov 2013 23:30:06 -0600 From: Nishanth Menon To: Stefan Roese CC: Paul Walmsley , "Nayak, Rajendra" , "tony@atomide.com" , Suman Anna , linux-omap Subject: Re: AM335x board with disabled RTC crashes Message-ID: <20131121053006.GA19129@kahuna> References: <528CC4CB.4000609@gmail.com> <528CC5C3.2010905@ti.com> <528CDAF6.7070905@ti.com> <528D8C08.1020201@gmail.com> <528D8CF0.1050406@roese.nl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <528D8CF0.1050406@roese.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 05:32-20131121, Stefan Roese wrote: > On 11/21/2013 05:28 AM, Stefan Roese wrote: > >>>> Disabling the RTC in the DT doesn't help (of course). So what's the > >>>> recommended way to disable this hwmod access to the RTC registers? > >>> > >>> > >>> http://www.spinics.net/lists/linux-omap/msg98207.html > >>> might help you - we had thought it might get queued for 3.12, but it > >>> was queued for 3.13 instead.. > > > > Unfortunately this patch doesn't fix the crash for me (yet). With this > > patch applied and the RTC DT node completely removed from am33xx.dtsi it > > works. But only disabling it (via status = "disabled" in the board dts > > file) doesn't work. > > > > I'll dig a bit deeper today... > > This (hacky) patch works, but I'm not sure if this is acceptable upstream: > > am335x-board_foo.dts: > > ... > > &rtc { > reg = <0x0 0x0>; > }; > You should be able to achieve the same effect as following (example from BBB) - though I dont see this defined in Documentation/devicetree/bindings/arm/omap/omap.txt I will allow the wisdom of others to comment better here :) diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts index 6b71ad9..a734ef4 100644 --- a/arch/arm/boot/dts/am335x-boneblack.dts +++ b/arch/arm/boot/dts/am335x-boneblack.dts @@ -66,6 +66,11 @@ status = "okay"; }; +&am335xrtc { + status = "disabled"; + ti,hwmods="disabled"; +}; + / { hdmi { compatible = "ti,tilcdc,slave"; diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index f6d8ffe..71bf2ec 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -373,7 +373,7 @@ ti,timer-pwm; }; - rtc@44e3e000 { + am335xrtc: rtc@44e3e000 { compatible = "ti,da830-rtc"; reg = <0x44e3e000 0x1000>; interrupts = <75