From patchwork Mon Jan 13 20:34:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 3480381 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7764DC02DC for ; Mon, 13 Jan 2014 20:34:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82F502015E for ; Mon, 13 Jan 2014 20:34:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9CCC20161 for ; Mon, 13 Jan 2014 20:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbaAMUeW (ORCPT ); Mon, 13 Jan 2014 15:34:22 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:35944 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbaAMUeV (ORCPT ); Mon, 13 Jan 2014 15:34:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora; h=Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ZN5poeBekjKYRCBKXbwiqRX953khsbwWZiEmVFUgKuM=; b=T+KtfC8ymWPqGO0kMrqNU3qp3BFNo9y/HB3JehvIhkFW98FiTpeRiqxe3kc1cSij2OwRexH3T4dOsyr1Dyhx8KoDKE32jk1BIozp9MVDK+D7LcrCcV/HRzwbI8naaJLo3deNq74XBxWMIpFVptchoCndirAPZegvT4ELLccxG0w=; Received: from n2100.arm.linux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:4f86]:42980) by pandora.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1W2oD3-0008Qc-KS; Mon, 13 Jan 2014 20:34:09 +0000 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1W2oD0-0006Mh-5W; Mon, 13 Jan 2014 20:34:06 +0000 Date: Mon, 13 Jan 2014 20:34:04 +0000 From: Russell King - ARM Linux To: Tony Lindgren Cc: dmaengine@vger.kernel.org, Vinod Koul , Dan Williams , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC 00/26] Migrate more OMAP DMA code to DMA engine Message-ID: <20140113203404.GF27282@n2100.arm.linux.org.uk> References: <20140102150836.GA3826@n2100.arm.linux.org.uk> <20140108012110.GL5074@atomide.com> <20140109152437.GB27282@n2100.arm.linux.org.uk> <20140113141811.GD27282@n2100.arm.linux.org.uk> <20140113173744.GA7746@atomide.com> <20140113185503.GE27282@n2100.arm.linux.org.uk> <20140113192630.GB7746@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140113192630.GB7746@atomide.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jan 13, 2014 at 11:26:31AM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [140113 10:57]: > > On Mon, Jan 13, 2014 at 09:37:45AM -0800, Tony Lindgren wrote: > > > * Russell King - ARM Linux [140113 08:48]: > > > > Any news on this? > > > > > > Sorry for the delay, now getting this: > > > > > > arch/arm/mach-omap1/dma.c: In function ‘omap1_system_dma_init’: > > > arch/arm/mach-omap1/dma.c:368: error: ‘struct omap_dma_dev_attr’ has no member named ‘chan’ > > > > Gah. Next incremental patch: > > Thanks, now getting this on omap1: > > # dmesg | grep -i dma > DMA: preallocated 256 KiB pool for atomic coherent allocations > OMAP DMA hardware version 1 > DMA capabilities: 0000000c:00000000:01ff:003f:007f > omap-dma-engine omap-dma-engine: invalid resource > omap-dma-engine: probe of omap-dma-engine failed with error -22 > mmci-omap mmci-omap.1: unable to obtain TX DMA engine channel 54 > mmci-omap mmci-omap.1: unable to obtain RX DMA engine channel 55 Sigh... let's give it the iomem resource then: diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c index 1b1b64647def..4be601b638d7 100644 --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c @@ -261,6 +261,8 @@ static const struct platform_device_info omap_dma_dev_info = { .name = "omap-dma-engine", .id = -1, .dma_mask = DMA_BIT_MASK(32), + .res = res, + .num_res = 1, }; static struct omap_system_dma_plat_info dma_plat_info __initdata = {