From patchwork Sat Feb 22 14:15:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 3701151 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 35A3DBF13A for ; Sat, 22 Feb 2014 14:15:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4B9E9201C8 for ; Sat, 22 Feb 2014 14:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECE52201BF for ; Sat, 22 Feb 2014 14:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbaBVOPf (ORCPT ); Sat, 22 Feb 2014 09:15:35 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:46853 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750937AbaBVOPe (ORCPT ); Sat, 22 Feb 2014 09:15:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora; h=Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=1JIUSGMSLJ4x173J8n+r1vM1vtu0HClj2wJKcRRuG/0=; b=QFLUfeiV+ncLlG/SSrT29C+a+TugNOp1EbUEUZ2obk+J1A5AfU9BZ1Pck9yh9JNe5BsEi3CBokAl/xwBBL3Ed+h+xai9jLkG9NpivKxDL2DfXqZM4GQppA1qSASACtLJO6KV2RonevUatvNzkE5nhUorU2aRxcQoHK/33TLDfpE=; Received: from n2100.arm.linux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:4f86]:40100) by pandora.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1WHDMY-0004iI-OC; Sat, 22 Feb 2014 14:15:30 +0000 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1WHDMV-0003kM-Dx; Sat, 22 Feb 2014 14:15:27 +0000 Date: Sat, 22 Feb 2014 14:15:25 +0000 From: Russell King - ARM Linux To: Felipe Balbi Cc: Linux ARM Kernel Mailing List , Linux OMAP Mailing List Subject: Re: randconfig build error Message-ID: <20140222141525.GT27282@n2100.arm.linux.org.uk> References: <20140221155452.GH31902@saruman.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140221155452.GH31902@saruman.home> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 21, 2014 at 09:55:13AM -0600, Felipe Balbi wrote: > Here's the error I found: > > warning: (ARCH_HI3xxx && SOC_OMAP5 && ARCH_SHMOBILE_MULTI) selects HAVE_ARM_TWD which has unmet direct dependencies (SMP) > warning: (ARCH_HI3xxx && SOC_OMAP5 && ARCH_SHMOBILE_MULTI) selects HAVE_ARM_TWD which has unmet direct dependencies (SMP) > arch/arm/mach-prima2/common.c:23:20: warning: ‘sirfsoc_map_io’ defined but not used [-Wunused-function] > static __init void sirfsoc_map_io(void) > ^ > arch/arm/kernel/smp_twd.c: In function ‘twd_local_timer_of_register’: > arch/arm/kernel/smp_twd.c:391:20: error: ‘setup_max_cpus’ undeclared (first use in this function) > if (!is_smp() || !setup_max_cpus) > ^ > arch/arm/kernel/smp_twd.c:391:20: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [arch/arm/kernel/smp_twd.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [arch/arm/kernel] Error 2 > make: *** Waiting for unfinished jobs.... > > The funny part of that is that SOC_OMAP5, ARCH_SHMOBILE_MULTI, and > ARCH_HI3xxx have: > > select HAVE_ARM_TWD if SMP > > so how come we still select it if CONFIG_SMP=n on that particular > randconfig ? Are you entirely certian which kernel version you're building? v3.14-rc1 to my tip has this: The relevant bits are the "-" lines, which indicate that with v3.14-rc1, ARCH_HI3xxx would select HAVE_ARM_TWD without SMP set, and indeed, your config you attached has ARCH_HI3xxx set. diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig index 8f4649b301b2..1abae5f6a418 100644 --- a/arch/arm/mach-hisi/Kconfig +++ b/arch/arm/mach-hisi/Kconfig @@ -8,7 +8,7 @@ config ARCH_HI3xxx select CLKSRC_OF select GENERIC_CLOCKEVENTS select HAVE_ARM_SCU - select HAVE_ARM_TWD + select HAVE_ARM_TWD if SMP select HAVE_SMP select PINCTRL select PINCTRL_SINGLE diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 653b489479e0..e2ce4f8366a7 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -54,7 +54,7 @@ config SOC_OMAP5 select ARM_GIC select CPU_V7 select HAVE_ARM_SCU if SMP - select HAVE_ARM_TWD if LOCAL_TIMERS + select HAVE_ARM_TWD if SMP select HAVE_SMP select HAVE_ARM_ARCH_TIMER select ARM_ERRATA_798181 if SMP diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index 338640631e08..05fa505df585 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -8,7 +8,7 @@ config ARCH_SHMOBILE_MULTI select CPU_V7 select GENERIC_CLOCKEVENTS select HAVE_ARM_SCU if SMP - select HAVE_ARM_TWD if LOCAL_TIMERS + select HAVE_ARM_TWD if SMP select HAVE_SMP select ARM_GIC select MIGHT_HAVE_CACHE_L2X0