From patchwork Fri Oct 31 20:03:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5206701 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2C0E8C11AC for ; Fri, 31 Oct 2014 20:03:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 19F6C20160 for ; Fri, 31 Oct 2014 20:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 359EB20158 for ; Fri, 31 Oct 2014 20:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932687AbaJaUD0 (ORCPT ); Fri, 31 Oct 2014 16:03:26 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40202 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932270AbaJaUDV (ORCPT ); Fri, 31 Oct 2014 16:03:21 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 7686781B0A; Fri, 31 Oct 2014 21:03:19 +0100 (CET) Date: Fri, 31 Oct 2014 21:03:18 +0100 From: Pavel Machek To: Tony Lindgren Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Aaro Koskinen , Felipe Balbi , sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Tomi Valkeinen Subject: Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900) Message-ID: <20141031200318.GA6949@amd> References: <20141019090107.GA19132@amd> <201410262222.39892@pali> <20141026215548.GA9004@amd> <201410262323.17891@pali> <20141027195209.GP2560@atomide.com> <20141027223114.GU2560@atomide.com> <20141028220450.GA27667@amd> <20141028221124.GT2542@atomide.com> <20141029084637.GA30662@amd> <20141029140943.GX2542@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141029140943.GX2542@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! I tried enabling audio. It works ...sometimes... after fixing kconfig. But I'm getting WARN_ON, about 50% of time. Ideas welcome. Pavel [ 2.398681] rx51-audio n900-audio: GPIO lookup for consumer speaker-amplifier [ 2.398681] rx51-audio n900-audio: using device tree for GPIO lookup [ 2.398742] of_get_named_gpiod_flags: parsed 'speaker-amplifier-gpios' property of node '/n900-audio[0]' - status (0) [ 2.404663] rx51-audio n900-audio: Failed to add TPA6130A2 controls [ 2.411010] rx51-audio n900-audio: ASoC: failed to init TLV320AIC34: -19 [ 2.416992] rx51-audio n900-audio: ASoC: failed to instantiate card -19 [ 2.423370] gpiod_unexport: invalid GPIO [ 2.429077] ------------[ cut here ]------------ [ 2.434661] WARNING: CPU: 0 PID: 6 at drivers/gpio/gpiolib.c:864 gpiod_free+0x2c/0x44() [ 2.440399] Modules linked in: [ 2.445892] CPU: 0 PID: 6 Comm: kworker/u2:0 Tainted: G W 3.18.0-rc1-omap3-67808-gc4dc985-dirty #554 [ 2.458648] Workqueue: deferwq deferred_probe_work_func [ 2.464080] Backtrace: [ 2.469573] [] (dump_backtrace) from [] (show_stack+0x18/0x1c) [ 2.475189] r6:00000360 r5:00000009 r4:00000000 r3:00000000 [ 2.480895] [] (show_stack) from [] (dump_stack+0x20/0x28) [ 2.486663] [] (dump_stack) from [] (warn_slowpath_common+0x6c/0x8c) [ 2.492584] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x24/0x2c) [ 2.498626] r8:c079e394 r7:00000000 r6:00000001 r5:00000001 r4:00000000 [ 2.504821] [] (warn_slowpath_null) from [] (gpiod_free+0x2c/0x44) [ 2.511199] [] (gpiod_free) from [] (gpiod_put+0x10/0x14) [ 2.517608] r4:c079e330 r3:ffffffe0 [ 2.523895] [] (gpiod_put) from [] (snd_soc_jack_free_gpios+0x4c/0x60) [ 2.530517] [] (snd_soc_jack_free_gpios) from [] (rx51_card_remove+0x1c/0x2c) [ 2.537384] r7:00000001 r6:cfb76d80 r5:cf991010 r4:ffffffed [ 2.544158] [] (rx51_card_remove) from [] (snd_soc_register_card+0xabc/0x13b4) [ 2.557525] [] (snd_soc_register_card) from [] (devm_snd_soc_register_card+0x34/0x70) [ 2.571624] r10:00000000 r9:00000000 r8:0000002c r7:cf96d410 r6:c079e2d8 r5:cf3f2250 [ 2.579193] r4:c079e394 [ 2.586517] [] (devm_snd_soc_register_card) from [] (rx51_soc_probe+0x190/0x2e8) [ 2.601348] r7:cf96d410 r6:c079e2d8 r5:cf3f2050 r4:00000000 [ 2.608947] [] (rx51_soc_probe) from [] (platform_drv_probe+0x50/0xac) [ 2.616516] r7:c079e2ec r6:fffffdfb r5:cf96d410 r4:ffffffed [ 2.624176] [] (platform_drv_probe) from [] (driver_probe_device+0x10c/0x22c) [ 2.632049] r7:c079e2ec r6:00000000 r5:cf96d410 r4:c08b8ab0 [ 2.639984] [] (driver_probe_device) from [] (__device_attach+0x48/0x4c) [ 2.647918] r8:cf025700 r7:cf86c000 r6:c02a21c8 r5:cf96d410 r4:c079e2ec r3:c02a3cb0 [ 2.656005] [] (__device_attach) from [] (bus_for_each_drv+0x4c/0x94) [ 2.664093] r5:cf96d410 r4:00000000 [ 2.672058] [] (bus_for_each_drv) from [] (device_attach+0x78/0x90) [ 2.680114] r6:c0787fa0 r5:cf96d444 r4:cf96d410 [ 2.688110] [] (device_attach) from [] (bus_probe_device+0x8c/0xb0) [ 2.696166] r6:c0787fa0 r5:cf96d410 r4:cf96d410 r3:cf8410c0 [ 2.704284] [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) [ 2.720275] r6:c0787f44 r5:c0787f50 r4:cf96d410 r3:c07885c4 [ 2.728363] [] (deferred_probe_work_func) from [] (process_one_work+0x120/0x338) [ 2.744140] r6:cf803e00 r5:c0787f68 r4:cf838280 r3:c02a1920 [ 2.752105] [] (process_one_work) from [] (worker_thread+0x158/0x518) [ 2.760070] r10:00000088 r9:cf838280 r8:cf838298 r7:00000001 r6:cf803e10 r5:cf86c000 [ 2.768035] r4:cf803e00 [ 2.775695] [] (worker_thread) from [] (kthread+0xc8/0xe4) [ 2.783477] r10:00000000 r9:00000000 r8:00000000 r7:c004c34c r6:cf838280 r5:cf839640 [ 2.791320] r4:00000000 [ 2.798889] [] (kthread) from [] (ret_from_fork+0x14/0x3c) [ 2.806518] r7:00000000 r6:00000000 r5:c0050c44 r4:cf839640 [ 2.814178] ---[ end trace 7377fd58b39bf1ee ]--- [ 2.821899] rx51-audio n900-audio: snd_soc_register_card failed (-19) [ 2.831146] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_lens_cover[0]' - status (0) [ 2.831237] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_focus[0]' - status (0) [ 2.831329] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_capture[0]' - status (0) [ 2.831390] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/lock_button[0]' - status (0) [ 2.831451] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/keypad_slide[0]' - status (0) [ 2.831512] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/proximity_sensor[0]' - status (0) [ 2.832733] input: gpio_keys as /devices/gpio_keys/input/input5 [ 2.857971] twl_rtc 48070000.i2c:twl@48:rtc: setting system clock to 2014-10-31 19:54:47 UTC (1414785287) [ 3.777465] musb-hdrc.0.auto: registering UDC driver [g_ether] [ 3.777679] using random self ethernet address [ 3.785003] using random host ethernet address [ 3.791900] g_ether gadget: adding config #1 'CDC Ethernet (ECM)'/c0793078 [ 3.791961] g_ether gadget: adding 'cdc_ethernet'/cf3ef300 to config 'CDC Ethernet (ECM)'/c0793078 [ 3.793579] usb0: HOST MAC 26:c1:fc:d6:eb:34 [ 3.800994] usb0: MAC be:19:8e:16:b0:da [ 3.807708] g_ether gadget: CDC Ethernet: dual speed IN/ep1in OUT/ep1out NOTIFY/ep2in commit 85a6aea58dbfe1068098d4160c17d3dad530ea50 Author: Pavel Date: Thu Oct 30 23:35:31 2014 +0100 Nokia N900 audio driver should be selectable even without RX51 support enabled (as is the case with RX51 booting using device tree). Signed-off-by: Pavel Machek diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index d44463a..0d7b707 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810 config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51" - depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C + depends on SND_OMAP_SOC && ARM && I2C select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X select SND_SOC_TPA6130A2