From patchwork Fri Jan 23 22:36:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 5698031 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 231FFC058D for ; Fri, 23 Jan 2015 22:36:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8549120328 for ; Fri, 23 Jan 2015 22:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50E5E202C8 for ; Fri, 23 Jan 2015 22:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbbAWWgk (ORCPT ); Fri, 23 Jan 2015 17:36:40 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:47637 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbbAWWgj (ORCPT ); Fri, 23 Jan 2015 17:36:39 -0500 Received: by mail-wg0-f42.google.com with SMTP id x13so68496wgg.1; Fri, 23 Jan 2015 14:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=ONrUOnpBSnUECkIO9MWfT1c5H6irlQBkQR6lMjQ15ec=; b=wDTvktUk51L5SRaOmjW9LliZEl9BBJToAlzQthitXdJ5CGGzpX8A257fgIV6U5VuOR KTVbx1C4MLM4PNaSAtqpGatc7kVxqxshSl6GEf9QXBThChx3JJIR43aM0TtrEGsG9SCc K4+0PM39kMepT6hR1A45ZWvH5HRGJimpmfK0uSG+Mb1+7AzqeUHh1MjQjn2zBfGdvBhj c/VKLgTO+LF7CLEvzx8ASB2kJ1GVxDkaZk9gj6uUjxPIyuGYzUTfA6KfQ+F6ZxB16Zng 0/1lfD1smXN+q+vn6mMKVRy+BzFL4aYL844eWWSK99yQC09zpJZva8a/obZB1kXUMvR/ HN/w== X-Received: by 10.194.109.9 with SMTP id ho9mr18796398wjb.29.1422052598218; Fri, 23 Jan 2015 14:36:38 -0800 (PST) Received: from pali-latitude.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id ei5sm3557904wid.2.2015.01.23.14.36.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Jan 2015 14:36:37 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: "linux-omap" Subject: Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken Date: Fri, 23 Jan 2015 23:36:36 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-44-generic; KDE/4.14.2; x86_64; ; ) Cc: Linux Kernel Mailing List , Aaro Koskinen , Tony Lindgren , Sebastian Reichel , Ivaylo Dimitrov , Pavel Machek , Russell King , linux-arm-kernel@lists.infradead.org, Laura Abbott References: <201501232239.55801@pali> In-Reply-To: <201501232239.55801@pali> MIME-Version: 1.0 Message-Id: <201501232336.36187@pali> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > Hello, > > when I boot zImage with appended DT n900 in qemu > fdt_open_into() function called from file > arch/arm/boot/compressed/atags_to_fdt.c (in function > atags_to_fdt) always returns -FDT_ERR_NOSPACE. > > It means that all ATAGS (including cmdline arguments) passed > by bootloader are ignored. > > On real n900 device I see that booted DT version also ignore > cmdline arguments from bootloader. I cannot debug decompress > code on real device, but I think it is same problem as in > qemu. Looks like this quick patch is fixing above problem: diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 68be901..4a7d75b 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -268,7 +268,7 @@ restart: adr r0, LC0 * area. No GOT fixup has occurred yet, but none of the * code we're about to call uses any global variable. */ - add sp, sp, #0x10000 + add sp, sp, #0x20000 stmfd sp!, {r0-r3, ip, lr} mov r0, r8 mov r1, r6 @@ -289,7 +289,7 @@ restart: adr r0, LC0 bleq atags_to_fdt ldmfd sp!, {r0-r3, ip, lr} - sub sp, sp, #0x10000 + sub sp, sp, #0x20000 #endif mov r8, r6 @ use the appended device tree