From patchwork Wed Feb 18 15:19:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 5844731 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5277B9F30C for ; Wed, 18 Feb 2015 15:20:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A1D322015E for ; Wed, 18 Feb 2015 15:20:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CABE4200F4 for ; Wed, 18 Feb 2015 15:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbbBRPTw (ORCPT ); Wed, 18 Feb 2015 10:19:52 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38225 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbBRPTv (ORCPT ); Wed, 18 Feb 2015 10:19:51 -0500 Received: by mail-wi0-f175.google.com with SMTP id r20so41790457wiv.2; Wed, 18 Feb 2015 07:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=W/ghY24QXRe5AKCfM4N9OcY6u0pc68IH5sIt/qzsU9g=; b=B/J1QqMtA56qPVorjinqUJQcwk3NtqQJ2a528MONJ5u/NuuCWROYuAy7KFI8dAVU5s Adfd7oWmADo4Ryu05ny6qeaMlP/J8d88NeoDOcql0Tm9DOLclp39Rr/F9yI8ixL9SeuQ YyTUciZKTXgo9WrgQwtORRY6LkKSMGtNf0B3W6XTVn5jgGxorWF3KnqfYyaIBEntFBcs fgpeIfuBgsidHv6eEH9k0AkpHO3Npr29v5keO0mc/dmXX2fQ2NsVS+Wk0kNQXWxHNkMC pSmsu/FBJ5CbVgz8/hEbLCo7HWC9Ji9nFPKbGaDhdK2KGU/JtcCcsoRVr/DqvUpyfZcd bIEg== X-Received: by 10.194.190.111 with SMTP id gp15mr10054847wjc.132.1424272789615; Wed, 18 Feb 2015 07:19:49 -0800 (PST) Received: from pali-latitude.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id bf8sm24115630wjb.37.2015.02.18.07.19.47 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Feb 2015 07:19:48 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900 Date: Wed, 18 Feb 2015 16:19:46 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-45-generic; KDE/4.14.2; x86_64; ; ) Cc: linux-omap@vger.kernel.org, Kevin Hilman , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, Ivaylo Dimitrov , Nishanth Menon References: <20150105230228.GO4081@atomide.com> In-Reply-To: <20150105230228.GO4081@atomide.com> MIME-Version: 1.0 Message-Id: <201502181619.46278@pali> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday 06 January 2015 00:02:29 Tony Lindgren wrote: > Revert "ARM: dts: Disable smc91x on n900 until bootloader > dependency is removed". We've now fixed the issues that > caused problems with uninitialized hardware depending on > the bootloader version. Mostly things got fixed with > the following commits: > > 9a894953a97b ("ARM: dts: Fix bootloader version dependencies > by muxing n900 smc91x pins") 7d2911c43815 ("net: smc91x: Fix > gpios for device tree based booting") > > Note that this only affects the early development boards > with Ethernet that we still have in a few automated boot > test systems. > > Signed-off-by: Tony Lindgren > > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -702,9 +702,6 @@ > > ethernet@gpmc { > compatible = "smsc,lan91c94"; > - > - status = "disabled"; > - > interrupt-parent = <&gpio2>; > interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ > reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 > */ Hello Tony, to make smc ethernet working in n900 qemu I needed to apply this patch: With this patch I see in dmesg: [ 20.577911] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: smc_probe [ 20.580535] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: bank signature probe returned 0x3300 [ 20.585327] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: revision = 0x3391 [ 20.590087] smc91x.c: v1.1, sep 22 2004 by Nicolas Pitre [ 20.593627] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc_reset [ 20.596832] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc_phy_detect [ 20.611938] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: smc_shutdown [ 20.615875] smc91x 2000000.ethernet eth0: SMC91C11xFD (rev 1) at d08be000 IRQ 166 [ 20.618682] [ 20.621124] smc91x 2000000.ethernet eth0: Ethernet addr: 52:54:00:12:34:56 [ 20.624938] smc91x 2000000.ethernet eth0: No PHY found (and eth0 exists in ifconfig) If I do not apply my patch I got this error message: [ 22.134704] smc91x 2000300.ethernet (unnamed net_device) (uninitialized): smc91x: bank signature probe returned 0x0000 [ 22.140014] smc91x: not found (-19). and no ethernet device was registered. With 2.6.28 kernel with N900 patches (but smc91x is unmodified!) ethernet device is working fine. diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index ff36fbe..d96eeb8 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -770,7 +770,8 @@ compatible = "smsc,lan91c94"; interrupt-parent = <&gpio2>; interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ - reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ +// reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ + reg = <1 0x0 0xf>; /* 16 byte IO range at offset 0x300 */ bank-width = <2>; pinctrl-names = "default"; pinctrl-0 = <ðernet_pins>;