From patchwork Tue Apr 26 19:47:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 8944001 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E49D7BF440 for ; Tue, 26 Apr 2016 19:48:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE728200FE for ; Tue, 26 Apr 2016 19:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB9EF2015A for ; Tue, 26 Apr 2016 19:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbcDZTsU (ORCPT ); Tue, 26 Apr 2016 15:48:20 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:39141 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbcDZTrD (ORCPT ); Tue, 26 Apr 2016 15:47:03 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Apr 2016 15:47:03 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 26 Apr 2016 15:47:01 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-omap@vger.kernel.org Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 0293DC90045; Tue, 26 Apr 2016 15:46:55 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3QJl0YV38535214; Tue, 26 Apr 2016 19:47:00 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3QJkxIk020968; Tue, 26 Apr 2016 15:47:00 -0400 Received: from paulmck-ThinkPad-W541 ([9.70.82.191]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u3QJkxrh020934; Tue, 26 Apr 2016 15:46:59 -0400 Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 26EF216C2CC7; Tue, 26 Apr 2016 12:47:37 -0700 (PDT) Date: Tue, 26 Apr 2016 12:47:37 -0700 From: "Paul E. McKenney" To: Tony Lindgren Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, Russell King , Steven Rostedt , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426194737.GM3715@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1461617335-22372-1-git-send-email-paulmck@linux.vnet.ibm.com> <20160426150031.GP5995@atomide.com> <20160426175214.GJ3715@linux.vnet.ibm.com> <20160426182939.GO5995@atomide.com> <20160426190755.GK3715@linux.vnet.ibm.com> <20160426193949.GP5995@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160426193949.GP5995@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042619-0057-0000-0000-000004270566 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 26, 2016 at 12:39:50PM -0700, Tony Lindgren wrote: > * Paul E. McKenney [160426 12:08]: > > On Tue, Apr 26, 2016 at 11:29:39AM -0700, Tony Lindgren wrote: > > > * Paul E. McKenney [160426 10:53]: > > > > Does the following patch help? > > > > > > It just changes the output.. See below. > > > > Ah -- you need both patches. > > Oops sorry, I though I had the first one already from next.. > > > These are on -rcu at: > > > > 501889db6fee (arm: Use _rcuidle tracepoint to allow use from idle) > > 99cd56ad86d2 (rm: Use more _rcuidle tracepoints to allow use from idle) > > With these omap4 is now OK. But omap3 produces yet another warning, > See below :) As Steven Rostedt said, whack-a-mole time... The previous two patches are still needed. Thanx, Paul ------------------------------------------------------------------------ commit c7ab21af6d959e3541ea52427472fc5dece75023 Author: Paul E. McKenney Date: Tue Apr 26 12:43:57 2016 -0700 arm: Additional _rcuidle tracepoints to allow use from idle This commit adds an _rcuidle suffix to a pair of trace events to prevent the following splat: > =============================== > [ INFO: suspicious RCU usage. ] > 4.6.0-rc5-next-20160426+ #1114 Not tainted > ------------------------------- > include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: > > > RCU used illegally from idle CPU! > rcu_scheduler_active = 1, debug_locks = 0 > RCU used illegally from extended quiescent state! > 2 locks held by swapper/0/0: > #0: (&oh->hwmod_key#30){......}, at: [] omap_hwmod_idle+0x18/0x44 > #1: (enable_lock){......}, at: [] clk_enable_lock+0x18/0x124 > > stack backtrace: > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114 > Hardware name: Generic OMAP36xx (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0xb0/0xe4) > [] (dump_stack) from [] (clk_core_disable+0x17c/0x348) > [] (clk_core_disable) from [] (clk_disable+0x24/0x30) > [] (clk_disable) from [] (_disable_clocks+0x18/0x7c) > [] (_disable_clocks) from [] (_idle+0x12c/0x230) > [] (_idle) from [] (omap_hwmod_idle+0x24/0x44) > [] (omap_hwmod_idle) from [] (omap_device_idle+0x3c/0x90) > [] (omap_device_idle) from [] (__rpm_callback+0x2c/0x60) > [] (__rpm_callback) from [] (rpm_callback+0x20/0x80) > [] (rpm_callback) from [] (rpm_suspend+0x100/0x768) > [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) > [] (__pm_runtime_suspend) from [] (omap2_gpio_prepare_for_idle+0x5 > c/0x70) > [] (omap2_gpio_prepare_for_idle) from [] (omap_sram_idle+0x140/0x2 > 44) > [] (omap_sram_idle) from [] (omap3_enter_idle_bm+0xfc/0x1ec) > [] (omap3_enter_idle_bm) from [] (cpuidle_enter_state+0x80/0x3d4) > [] (cpuidle_enter_state) from [] (cpu_startup_entry+0x198/0x3a0) > [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8) > [] (start_kernel) from [<8000807c>] (0x8000807c) Reported-by: Tony Lindgren Signed-off-by: Paul E. McKenney Cc: Tony Lindgren Cc: Russell King Cc: Steven Rostedt Cc: Cc: --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index fb74dc1f7520..4fa43c02d682 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) if (--core->enable_count > 0) return; - trace_clk_disable(core); + trace_clk_disable_rcuidle(core); if (core->ops->disable) core->ops->disable(core->hw); - trace_clk_disable_complete(core); + trace_clk_disable_complete_rcuidle(core); clk_core_disable(core->parent); }