From patchwork Tue Apr 26 20:06:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 8944101 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 25374BF29F for ; Tue, 26 Apr 2016 20:05:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 35165201EF for ; Tue, 26 Apr 2016 20:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B29201C7 for ; Tue, 26 Apr 2016 20:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752774AbcDZUFn (ORCPT ); Tue, 26 Apr 2016 16:05:43 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:49129 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbcDZUFm (ORCPT ); Tue, 26 Apr 2016 16:05:42 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Apr 2016 14:05:41 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 26 Apr 2016 14:05:38 -0600 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-omap@vger.kernel.org Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id DE2A81FF0049; Tue, 26 Apr 2016 14:05:22 -0600 (MDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3QK5bL728311740; Tue, 26 Apr 2016 20:05:37 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3QK5a9Q013960; Tue, 26 Apr 2016 16:05:36 -0400 Received: from paulmck-ThinkPad-W541 ([9.70.82.191]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u3QK5ZQf013937; Tue, 26 Apr 2016 16:05:35 -0400 Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id C140A16C0A16; Tue, 26 Apr 2016 13:06:13 -0700 (PDT) Date: Tue, 26 Apr 2016 13:06:13 -0700 From: "Paul E. McKenney" To: Tony Lindgren Cc: Steven Rostedt , linux-kernel@vger.kernel.org, mingo@kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426200613.GO3715@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1461617335-22372-1-git-send-email-paulmck@linux.vnet.ibm.com> <20160426150031.GP5995@atomide.com> <20160426175214.GJ3715@linux.vnet.ibm.com> <20160426182939.GO5995@atomide.com> <20160426190755.GK3715@linux.vnet.ibm.com> <20160426193949.GP5995@atomide.com> <20160426154414.7bb33de4@gandalf.local.home> <20160426195158.GR5995@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160426195158.GR5995@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042620-0029-0000-0000-000024210F29 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote: > * Steven Rostedt [160426 12:45]: > > *Whack* *Whack* *Whack*!!! > > > > Signed-off-by: Steven Rostedt > > --- > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index fb74dc1f7520..4fa43c02d682 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > > if (--core->enable_count > 0) > > return; > > > > - trace_clk_disable(core); > > + trace_clk_disable_rcuidle(core); > > > > if (core->ops->disable) > > core->ops->disable(core->hw); > > > > - trace_clk_disable_complete(core); > > + trace_clk_disable_complete_rcuidle(core); > > > > clk_core_disable(core->parent); > > } > > Now the mole shows up here! And the patch shows up here! Thanx, Paul ------------------------------------------------------------------------ commit d824fb6beb6e23ade51806e11a882528dc15ae98 Author: Paul E. McKenney Date: Tue Apr 26 13:03:51 2016 -0700 arm: Whack another event-trace-from-idle mole This commit appends a few _rcuidle suffixes to fix the following RCU-used-from-idle bug: > =============================== > [ INFO: suspicious RCU usage. ] > 4.6.0-rc5-next-20160426+ #1116 Not tainted > ------------------------------- > include/trace/events/rpm.h:95 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: > > > RCU used illegally from idle CPU! > rcu_scheduler_active = 1, debug_locks = 0 > RCU used illegally from extended quiescent state! > 1 lock held by swapper/0/0: > #0: (&(&dev->power.lock)->rlock){-.-...}, at: [] __rpm_callback+0x58/0x60 > > stack backtrace: > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1116 > Hardware name: Generic OMAP36xx (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0xb0/0xe4) > [] (dump_stack) from [] (rpm_suspend+0x580/0x768) > [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) > [] (__pm_runtime_suspend) from [] (omap2_gpio_prepare_for_idle+0x5c/0x70) > [] (omap2_gpio_prepare_for_idle) from [] (omap_sram_idle+0x140/0x244) > [] (omap_sram_idle) from [] (omap3_enter_idle_bm+0xfc/0x1ec) > [] (omap3_enter_idle_bm) from [] (cpuidle_enter_state+0x80/0x3d4) > [] (cpuidle_enter_state) from [] (cpu_startup_entry+0x198/0x3a0) > [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8) > [] (start_kernel) from [<8000807c>] (0x8000807c) In the immortal words of Steven Rostedt, "*Whack* *Whack* *Whack*!!!" Reported-by: Tony Lindgren Signed-off-by: Paul E. McKenney Cc: Tony Lindgren Cc: Russell King Cc: Steven Rostedt Cc: Cc: --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index d9358c202763..af4c38d41aff 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -301,7 +301,7 @@ static int rpm_idle(struct device *dev, int rpmflags) int (*callback)(struct device *); int retval; - trace_rpm_idle(dev, rpmflags); + trace_rpm_idle_rcuidle(dev, rpmflags); retval = rpm_check_suspend_allowed(dev); if (retval < 0) ; /* Conditions are wrong. */ @@ -337,7 +337,7 @@ static int rpm_idle(struct device *dev, int rpmflags) dev->power.request_pending = true; queue_work(pm_wq, &dev->power.work); } - trace_rpm_return_int(dev, _THIS_IP_, 0); + trace_rpm_return_int_rcuidle(dev, _THIS_IP_, 0); return 0; } @@ -352,7 +352,7 @@ static int rpm_idle(struct device *dev, int rpmflags) wake_up_all(&dev->power.wait_queue); out: - trace_rpm_return_int(dev, _THIS_IP_, retval); + trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval); return retval ? retval : rpm_suspend(dev, rpmflags | RPM_AUTO); }