diff mbox

ARM: dts: omap4-devkit8000: fix gpmc ranges property

Message ID 20170518130009.24199-1-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Uwe Kleine-König May 18, 2017, 1 p.m. UTC
With two separate &gpmc nodes the second ranges property overwrites the
first. So put nand and ethernet in a single node and merge the ranges.

While at it also fix the ethernet suffix.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

I don't have such a machine, so this isn't really tested. But I bet it
cannot be worse than the original.

Uwe

 arch/arm/boot/dts/omap3-devkit8000-common.dtsi | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Tony Lindgren May 26, 2017, 3:39 p.m. UTC | #1
* Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [170518 06:03]:
> With two separate &gpmc nodes the second ranges property overwrites the
> first. So put nand and ethernet in a single node and merge the ranges.
> 
> While at it also fix the ethernet suffix.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I don't have such a machine, so this isn't really tested. But I bet it
> cannot be worse than the original.

Yup thanks. Applying into omap-for-v4.13/dt as it seems it's been
clearly broken for a while and nobody noticed.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
index f330c69cc683..82aa9c4a0f1c 100644
--- a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
+++ b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
@@ -201,7 +201,8 @@ 
 };
 
 &gpmc {
-	ranges = <0 0 0x30000000 0x1000000>;       /* CS0: 16MB for NAND */
+	ranges = <0 0 0x30000000 0x1000000	/* CS0: 16MB for NAND */
+		  6 0 0x2c000000 0x1000000>;	/* CS6: 16MB for DM9000 */
 
 	nand@0,0 {
 		compatible = "ti,omap2-nand";
@@ -256,12 +257,8 @@ 
 			reg = <0x680000 0xf980000>;
 		};
 	};
-};
-
-&gpmc {
-	ranges = <6 0 0x2c000000 0x1000000>;       /* CS6: 16MB for DM9000 */
 
-	ethernet@0,0 {
+	ethernet@6,0 {
 		compatible = "davicom,dm9000";
 		reg =  <6 0x000 2
 			6 0x400 2>; /* CS6, offset 0 and 0x400, IO size 2 */