From patchwork Sat Sep 16 20:42:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9954479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CEBBB601D5 for ; Sat, 16 Sep 2017 20:42:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE6D128C9B for ; Sat, 16 Sep 2017 20:42:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B333428C9D; Sat, 16 Sep 2017 20:42:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C625B28C9C for ; Sat, 16 Sep 2017 20:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbdIPUmo (ORCPT ); Sat, 16 Sep 2017 16:42:44 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61614 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdIPUmn (ORCPT ); Sat, 16 Sep 2017 16:42:43 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0LyBrp-1dN7uA0rbh-015WME; Sat, 16 Sep 2017 22:42:35 +0200 From: Arnd Bergmann To: Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linus Walleij Cc: Arnd Bergmann , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: omap: omap_gpio_show_rev is not __init Date: Sat, 16 Sep 2017 22:42:21 +0200 Message-Id: <20170916204234.725130-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:AIUbWyQ2ijZBOMaRjiJ4t3oaYJCDptmZlV8LnlCoFAlpZTNW5b3 EDJVhW3vAk1DmIWo1Nj3L0khtb/wD+tDFqfDbQwrI8blLasR4lP/adFNT/q5YYlt3exiMX1 Fe1TGCv5DiHJXEzXhg8ybysAupIboUA6s+gtB3mgIjlTNLfaZbnstLU4xU0m9ndykcnLW69 pxUypNUFMuqAGKsC/2wAA== X-UI-Out-Filterresults: notjunk:1; V01:K0:iqebl3/GIeQ=:nwINSMw5QIkA3LC1IoKXTp xUcnG9xIsr6FpdtDM7SNNRUUCFukU9etDORC4efB66iF6Wxsz07BfUGiVT/pw5FVQ9k6XZt6B jcgVjQdr2A0WzmpmBMe8QBLKx0PEF0KAy6+V3DfnbtgI3Vzq1agh0aXKk1qNfTRBSarVjeWPb nHsVwygdrLbgjmiFakJDeFPhrqVLJYNFAOQXwNBCaEoKBpBebTyzXWgEoMP3NGFW1LqtDVLTe w/wA8Cm4dqigD/9aWfAQ2ebOvdxdcowxFdGDiOBDzQRPZZG1pR3ZOaGH56kixOAM2Crr08H9R 5Q/xgAdQbHJmoxOjabTTw4eSNW97EZ/lmDMdxTcBLr2CbBdW+QDfK6+xiyzuK13ClgmDqRiOa luhEmcAyefgHG4ibf96H4qXTN3KuyaEUNuG7rSVDcJBNJQrFRkhkR3Su1WNORWi+tTkwbtzXq rS0/PVxsvSww8JUmfTMi46XtJEZCKjOtf9Js5gGwz2HG1ndgZtSUO72Fy4PSqvjCzKl2ud410 aJTd4XjxOWtxQQmlj6uE8O63+kOtRgarcZlsPooDRGCTNN6lD0edfFJwHVNbmGrxK5WzaQ0ad cCTEnq+w++HP1xGZXQHCF5J23Y7OFIPKygOdsjGH2tiGyvX+c0dVlZdkRll33rqpluJV3oQ6r EkifUrDUSE/H4cdvrOLCP+qVjQgs/pDGJZnD4gfKwl0uzDYixw5KaOGn6OK0ZvSJO4LHKkfO7 0p3W3xwKVkzRijWENCimKYkNV5IVZWSH3x5shw== Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The probe function calls omap_gpio_show_rev(), which on most compilers is inlined, but on the old gcc-4.6 is not, causing a valid warning about the incorrect __init annotation: WARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev() The function omap_gpio_probe() references the function __init omap_gpio_show_rev(). This is often because omap_gpio_probe lacks a __init annotation or the annotation of omap_gpio_show_rev is wrong. This removes the __init. Signed-off-by: Arnd Bergmann Acked-by: Santosh Shilimkar --- drivers/gpio/gpio-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index dbf869fb63ce..22d7d4838265 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1010,7 +1010,7 @@ static void omap_gpio_set(struct gpio_chip *chip, unsigned offset, int value) /*---------------------------------------------------------------------*/ -static void __init omap_gpio_show_rev(struct gpio_bank *bank) +static void omap_gpio_show_rev(struct gpio_bank *bank) { static bool called; u32 rev;