| Message ID | 20171010133245.jlwto3gpmin5bmtw@lenoch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 10/10/17 16:32, Ladislav Michl wrote: > commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned > pointer to omap_nand_info to the platform drvdata in probe function > just to be reasigned later to the pointer to mtd_info, which is > what remove function expects it to be. Remove useless assignment. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> Tested on dra7-evm. Acked-by: Roger Quadros <rogerq@ti.com> > --- > drivers/mtd/nand/omap2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index 01368a8f9e3f..a97c1aeed55e 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev) > if (err) > return err; > > - platform_set_drvdata(pdev, info); > info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs); > if (!info->ops) { > dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n"); >
On Tue, 10 Oct 2017 15:32:45 +0200 Ladislav Michl <ladis@linux-mips.org> wrote: > commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned > pointer to omap_nand_info to the platform drvdata in probe function > just to be reasigned later to the pointer to mtd_info, which is > what remove function expects it to be. Remove useless assignment. > Applied. Thanks, Boris > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- > drivers/mtd/nand/omap2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index 01368a8f9e3f..a97c1aeed55e 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev) > if (err) > return err; > > - platform_set_drvdata(pdev, info); > info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs); > if (!info->ops) { > dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 01368a8f9e3f..a97c1aeed55e 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev) if (err) return err; - platform_set_drvdata(pdev, info); info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs); if (!info->ops) { dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");
commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned pointer to omap_nand_info to the platform drvdata in probe function just to be reasigned later to the pointer to mtd_info, which is what remove function expects it to be. Remove useless assignment. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> --- drivers/mtd/nand/omap2.c | 1 - 1 file changed, 1 deletion(-)