From patchwork Fri Nov 3 07:23:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ladislav Michl X-Patchwork-Id: 10039587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 356CD602DA for ; Fri, 3 Nov 2017 07:23:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 270C4294C1 for ; Fri, 3 Nov 2017 07:23:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BCB92951C; Fri, 3 Nov 2017 07:23:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74C90294C1 for ; Fri, 3 Nov 2017 07:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754624AbdKCHXi (ORCPT ); Fri, 3 Nov 2017 03:23:38 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:50398 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611AbdKCHXi (ORCPT ); Fri, 3 Nov 2017 03:23:38 -0400 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990417AbdKCHXgqSbAx (ORCPT ); Fri, 3 Nov 2017 08:23:36 +0100 Date: Fri, 3 Nov 2017 08:23:35 +0100 From: Ladislav Michl To: linux-omap@vger.kernel.org Cc: Roger Quadros , Tony Lindgren Subject: bank-width property of gpmc child nodes Message-ID: <20171103072335.jwphezhpj62s27tn@lenoch> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi there, gpmc code checks for bank-width property which reassigns device_width previously setup in gpmc_read_settings_dt using 'gpmc,device-width' Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt does not mention 'bank-width' at all and 'gpmc,device-width' is marked as optional. gpmc_cs_program_settings bails out with -EINVAL when this property is not set. Is there something I'm missing (historical context) of following patch and fixing documentation is okay? ladis 8<----------------------- Subject: [PATCH] memory: omap-gpmc: Remove bank-width DT property 'bank-width' is undocumented and unneeded as value of device_width is previously read from documented 'gpmc,device-width' property. Signed-off-by: Ladislav Michl --- drivers/memory/omap-gpmc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 24b584b74d84..9322ff1791df 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2151,14 +2151,6 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, /* disable write protect */ gpmc_configure(GPMC_CONFIG_WP, 0); gpmc_s.device_nand = true; - } else { - ret = of_property_read_u32(child, "bank-width", - &gpmc_s.device_width); - if (ret < 0) { - dev_err(&pdev->dev, "%pOF has no 'bank-width' property\n", - child); - goto err; - } } /* Reserve wait pin if it is required and valid */