| Message ID | 20171115162458.rtompijrsaobdemk@lenoch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
+Rob and the DT ML On Wed, 15 Nov 2017 17:24:58 +0100 Ladislav Michl <ladis@linux-mips.org> wrote: > Compatible property is required for OMAP2+ mtd driver. Also > add INT pin gpio description and delete unused dma-channel > property. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Acked-by: Roger Quadros <rogerq@ti.com> > --- > > Changes in v5: > - renamed R/B pin to INT pin > > Changes in v4: > - new patch > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mtd/gpmc-onenand.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > index b6e8bfd024f4..e9f01a963a0a 100644 > --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > +++ b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > @@ -9,13 +9,14 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt > > Required properties: > > + - compatible: "ti,omap2-onenand" Don't you break backward compat by adding this new requirement? > - reg: The CS line the peripheral is connected to > - - gpmc,device-width Width of the ONENAND device connected to the GPMC > + - gpmc,device-width: Width of the ONENAND device connected to the GPMC > in bytes. Must be 1 or 2. > > Optional properties: > > - - dma-channel: DMA Channel index > + - int-gpios: GPIO specifier for the INT pin. > > For inline partition table parsing (optional): > > @@ -35,6 +36,7 @@ Example for an OMAP3430 board: > #size-cells = <1>; > > onenand@0 { > + compatible = "ti,omap2-onenand"; > reg = <0 0 0>; /* CS0, offset 0 */ > gpmc,device-width = <2>; > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 30, 2017 at 11:25:44AM +0100, Boris Brezillon wrote: > +Rob and the DT ML > > On Wed, 15 Nov 2017 17:24:58 +0100 > Ladislav Michl <ladis@linux-mips.org> wrote: > > > Compatible property is required for OMAP2+ mtd driver. Also > > add INT pin gpio description and delete unused dma-channel > > property. > > > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > > Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Acked-by: Roger Quadros <rogerq@ti.com> > > --- > > > > Changes in v5: > > - renamed R/B pin to INT pin > > > > Changes in v4: > > - new patch > > > > Changes in v3: None > > Changes in v2: None > > > > Documentation/devicetree/bindings/mtd/gpmc-onenand.txt | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > > index b6e8bfd024f4..e9f01a963a0a 100644 > > --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > > +++ b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > > @@ -9,13 +9,14 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt > > > > Required properties: > > > > + - compatible: "ti,omap2-onenand" > > Don't you break backward compat by adding this new requirement? I was told it is okay in this case as OneNAND conversion to DT is unfinished. There was compat fixup code in earlier versions of patchset and it was dropped later. If others see it opposite way I can add it back. > > - reg: The CS line the peripheral is connected to > > - - gpmc,device-width Width of the ONENAND device connected to the GPMC > > + - gpmc,device-width: Width of the ONENAND device connected to the GPMC > > in bytes. Must be 1 or 2. > > > > Optional properties: > > > > - - dma-channel: DMA Channel index > > + - int-gpios: GPIO specifier for the INT pin. > > > > For inline partition table parsing (optional): > > > > @@ -35,6 +36,7 @@ Example for an OMAP3430 board: > > #size-cells = <1>; > > > > onenand@0 { > > + compatible = "ti,omap2-onenand"; > > reg = <0 0 0>; /* CS0, offset 0 */ > > gpmc,device-width = <2>; > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ladislav, On 30/11/17 15:09, Ladislav Michl wrote: > On Thu, Nov 30, 2017 at 11:25:44AM +0100, Boris Brezillon wrote: >> +Rob and the DT ML >> >> On Wed, 15 Nov 2017 17:24:58 +0100 >> Ladislav Michl <ladis@linux-mips.org> wrote: >> >>> Compatible property is required for OMAP2+ mtd driver. Also >>> add INT pin gpio description and delete unused dma-channel >>> property. >>> >>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org> >>> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >>> Acked-by: Roger Quadros <rogerq@ti.com> >>> --- >>> >>> Changes in v5: >>> - renamed R/B pin to INT pin >>> >>> Changes in v4: >>> - new patch >>> >>> Changes in v3: None >>> Changes in v2: None >>> >>> Documentation/devicetree/bindings/mtd/gpmc-onenand.txt | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt >>> index b6e8bfd024f4..e9f01a963a0a 100644 >>> --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt >>> +++ b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt >>> @@ -9,13 +9,14 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt >>> >>> Required properties: >>> >>> + - compatible: "ti,omap2-onenand" >> >> Don't you break backward compat by adding this new requirement? > > I was told it is okay in this case as OneNAND conversion to DT is unfinished. > There was compat fixup code in earlier versions of patchset and it was dropped > later. If others see it opposite way I can add it back. > If it is possible not to break backward compatibility then we shouldn't. Only if things are getting real messy because of the poor way the earlier DT implementation was done we can consider it as an exception. I thought we rely on GPMC timings entirely from the DT now and so things don't work with older DT nodes? >>> - reg: The CS line the peripheral is connected to >>> - - gpmc,device-width Width of the ONENAND device connected to the GPMC >>> + - gpmc,device-width: Width of the ONENAND device connected to the GPMC >>> in bytes. Must be 1 or 2. >>> >>> Optional properties: >>> >>> - - dma-channel: DMA Channel index >>> + - int-gpios: GPIO specifier for the INT pin. >>> >>> For inline partition table parsing (optional): >>> >>> @@ -35,6 +36,7 @@ Example for an OMAP3430 board: >>> #size-cells = <1>; >>> >>> onenand@0 { >>> + compatible = "ti,omap2-onenand"; >>> reg = <0 0 0>; /* CS0, offset 0 */ >>> gpmc,device-width = <2>; >>>
Roger, On Fri, Dec 15, 2017 at 12:18:59PM +0200, Roger Quadros wrote: > Ladislav, > > On 30/11/17 15:09, Ladislav Michl wrote: > > On Thu, Nov 30, 2017 at 11:25:44AM +0100, Boris Brezillon wrote: > >> +Rob and the DT ML > >> > >> On Wed, 15 Nov 2017 17:24:58 +0100 > >> Ladislav Michl <ladis@linux-mips.org> wrote: > >> > >>> Compatible property is required for OMAP2+ mtd driver. Also > >>> add INT pin gpio description and delete unused dma-channel > >>> property. > >>> > >>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > >>> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > >>> Acked-by: Roger Quadros <rogerq@ti.com> > >>> --- > >>> > >>> Changes in v5: > >>> - renamed R/B pin to INT pin > >>> > >>> Changes in v4: > >>> - new patch > >>> > >>> Changes in v3: None > >>> Changes in v2: None > >>> > >>> Documentation/devicetree/bindings/mtd/gpmc-onenand.txt | 6 ++++-- > >>> 1 file changed, 4 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > >>> index b6e8bfd024f4..e9f01a963a0a 100644 > >>> --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > >>> +++ b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > >>> @@ -9,13 +9,14 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt > >>> > >>> Required properties: > >>> > >>> + - compatible: "ti,omap2-onenand" > >> > >> Don't you break backward compat by adding this new requirement? > > > > I was told it is okay in this case as OneNAND conversion to DT is unfinished. > > There was compat fixup code in earlier versions of patchset and it was dropped > > later. If others see it opposite way I can add it back. > > > > If it is possible not to break backward compatibility then we shouldn't. > Only if things are getting real messy because of the poor way the earlier DT > implementation was done we can consider it as an exception. Well, it is possible to reintroduce fixup. Based on other posts on linux-omap mailing list, it seems that n900, etc. support is still under heavy development, so people are updating both kernel and dtb. That's why I happily agreed on removing fixup. Of course I'd like to hear opinion from n8x0 and n900 people and also would be very happy if someone could finally test on OMAP2 device. > I thought we rely on GPMC timings entirely from the DT now and so things don't > work with older DT nodes? Well, they do work as long as DT contains correct timings. Mainline driver just ignores them a does calculations on its own, so it works even with wrong DT timings as long as bootloader configured something reasonable (otherwise it doe not work at all). This is no longer the case. Now, driver is expecting reasonable timings, enough good to get device probed. Driver then calculates optimized timings based on actual OneNAND chip ised. Thank you, ladis -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt index b6e8bfd024f4..e9f01a963a0a 100644 --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt +++ b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt @@ -9,13 +9,14 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt Required properties: + - compatible: "ti,omap2-onenand" - reg: The CS line the peripheral is connected to - - gpmc,device-width Width of the ONENAND device connected to the GPMC + - gpmc,device-width: Width of the ONENAND device connected to the GPMC in bytes. Must be 1 or 2. Optional properties: - - dma-channel: DMA Channel index + - int-gpios: GPIO specifier for the INT pin. For inline partition table parsing (optional): @@ -35,6 +36,7 @@ Example for an OMAP3430 board: #size-cells = <1>; onenand@0 { + compatible = "ti,omap2-onenand"; reg = <0 0 0>; /* CS0, offset 0 */ gpmc,device-width = <2>;