| Message ID | 20180117100819.GA4017@lenoch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/01/18 12:08, Ladislav Michl wrote: > Don't complain on -EPROBE_DEFER when when no PHY found, the driver > probe will be retried later. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > Acked-by: Tony Lindgren <tony@atomide.com> Acked-by: Roger Quadros <rogerq@ti.com> > --- > Changes: > - v2: None, just added Tony's ack > > drivers/usb/host/ehci-omap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c > index 854b146a457d..fd6170962a1a 100644 > --- a/drivers/usb/host/ehci-omap.c > +++ b/drivers/usb/host/ehci-omap.c > @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) > continue; > > ret = PTR_ERR(phy); > - dev_err(dev, "Can't get PHY device for port %d: %d\n", > - i, ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Can't get PHY device for port " > + "%d: %d\n", i, ret); > goto err_phy; > } > >
In you commit message, there is a typo "when when" 2018-01-17 22:41 GMT+09:00 Roger Quadros <rogerq@ti.com>: > On 17/01/18 12:08, Ladislav Michl wrote: >> Don't complain on -EPROBE_DEFER when when no PHY found, the driver ^^^^^^^^^^^^ thanks, jaejoong >> probe will be retried later. >> >> Signed-off-by: Ladislav Michl <ladis@linux-mips.org> >> Acked-by: Tony Lindgren <tony@atomide.com> > > Acked-by: Roger Quadros <rogerq@ti.com> > >> --- >> Changes: >> - v2: None, just added Tony's ack >> >> drivers/usb/host/ehci-omap.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c >> index 854b146a457d..fd6170962a1a 100644 >> --- a/drivers/usb/host/ehci-omap.c >> +++ b/drivers/usb/host/ehci-omap.c >> @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) >> continue; >> >> ret = PTR_ERR(phy); >> - dev_err(dev, "Can't get PHY device for port %d: %d\n", >> - i, ret); >> + if (ret != -EPROBE_DEFER) >> + dev_err(dev, "Can't get PHY device for port " >> + "%d: %d\n", i, ret); >> goto err_phy; >> } >> >> > > -- > cheers, > -roger > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 854b146a457d..fd6170962a1a 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) continue; ret = PTR_ERR(phy); - dev_err(dev, "Can't get PHY device for port %d: %d\n", - i, ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Can't get PHY device for port " + "%d: %d\n", i, ret); goto err_phy; }