From patchwork Fri Mar 30 17:50:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 10318249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 11BA96055B for ; Fri, 30 Mar 2018 17:51:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 009CD29053 for ; Fri, 30 Mar 2018 17:51:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E8B012A60D; Fri, 30 Mar 2018 17:51:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84B4429053 for ; Fri, 30 Mar 2018 17:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbeC3Ruy (ORCPT ); Fri, 30 Mar 2018 13:50:54 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49530 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbeC3Rux (ORCPT ); Fri, 30 Mar 2018 13:50:53 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 369BC80365; Fri, 30 Mar 2018 19:50:51 +0200 (CEST) Date: Fri, 30 Mar 2018 19:50:50 +0200 From: Pavel Machek To: Merlijn Wajer Cc: Tony Lindgren , Sebastian Reichel , Mark Brown , Liam Girdwood , Rob Herring , Lee Jones , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Dan Williams Subject: Re: omap4-droid4: voice call support was Re: [PATCHv5, 5/5] ARM: dts: omap4-droid4: add soundcard Message-ID: <20180330175050.GA26571@amd> References: <20180329014507.GM5700@atomide.com> <20180329133613.khldv72w3zj63vsk@earth.universe> <20180329135904.GN5700@atomide.com> <20180329154600.qhels5fqzzg364gj@earth.universe> <20180329163716.GA20743@amd> <20180329164113.GR5700@atomide.com> <20180329184007.GA27688@amd> <20180329215612.GS5700@atomide.com> <20180330103744.GA17404@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri 2018-03-30 15:07:24, Merlijn Wajer wrote: > On 30/03/18 12:37, Pavel Machek wrote: > > On Thu 2018-03-29 14:56:13, Tony Lindgren wrote: > >> * Pavel Machek [180329 18:41]: > >>> Thanks. I got call working including outgoing audio: in capture > >>> settings, right->mic 1, Mic1 + Mic2 in alsamixer -> 100%. But I had > >>> the other phone muted, so I don't yet know if such call would be of > >>> usable quality. > >> > >> Great, good to hear that :) > > > > I also got ofonod to work, with rather crazy hacks. But I now have > > incoming/outgoing calls with GUI :-). > > Would you mind sharing those hacks - I would like to play around with > ofonod as well. Maybe I can help with a way forward. Okay. Here's less hacky version of the hack, but still using AT commands. You still need to set up udev, as described in the other mail. And... it seems I can have a qmi connection, too, but that's topic for other email. Good luck, Pavel diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index 68b89862..3a9f4bc0 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -440,6 +440,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data) if (data->vendor != OFONO_VENDOR_SIMCOM) at_ack_delivery(sms); + return; + err: ofono_error("Unable to parse CMT notification"); } diff --git a/plugins/udevng.c b/plugins/udevng.c index ff5d41af..a4b18488 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -233,10 +233,11 @@ static gboolean setup_gobi(struct modem_info *modem) } } + DBG("qmi=%s net=%s mdm=%s gps=%s diag=%s", qmi, net, mdm, gps, diag); + if (qmi == NULL || mdm == NULL || net == NULL) return FALSE; - DBG("qmi=%s net=%s mdm=%s gps=%s diag=%s", qmi, net, mdm, gps, diag); ofono_modem_set_string(modem->modem, "Device", qmi); ofono_modem_set_string(modem->modem, "Modem", mdm); @@ -1250,6 +1251,7 @@ static struct { { "cinterion", setup_serial_modem }, { "nokiacdma", setup_serial_modem }, { "sim900", setup_serial_modem }, + { "g1", setup_serial_modem }, { "wavecom", setup_wavecom }, { "tc65", setup_tc65 }, { "ehs6", setup_ehs6 }, @@ -1578,8 +1580,6 @@ static struct { { "mbm", "cdc_ether", "0930" }, { "mbm", "cdc_ncm", "0930" }, { "hso", "hso" }, - { "gobi", "qmi_wwan" }, - { "gobi", "qcserial" }, { "sierra", "qmi_wwan", "1199" }, { "sierra", "qcserial", "1199" }, { "sierra", "sierra" }, @@ -1602,6 +1602,8 @@ static struct { { "telit", "cdc_acm", "1bc7", "0021" }, { "telitqmi", "qmi_wwan", "1bc7", "1201" }, { "telitqmi", "option", "1bc7", "1201" }, + { "telitqmi", "qmi_wwan", "22b8", "2a70" }, + { "telitqmi", "option", "22b8", "2a70" }, { "nokia", "option", "0421", "060e" }, { "nokia", "option", "0421", "0623" }, { "samsung", "option", "04e8", "6889" }, @@ -1717,10 +1719,12 @@ static void check_device(struct udev_device *device) return; } +#if 0 if ((g_str_equal(bus, "usb") == TRUE) || (g_str_equal(bus, "usbmisc") == TRUE)) check_usb_device(device); else +#endif add_serial_device(device); } @@ -1749,14 +1753,17 @@ static gboolean create_modem(gpointer key, gpointer value, gpointer user_data) if (g_str_equal(driver_list[i].name, modem->driver) == FALSE) continue; + DBG("Attempting modem setup, driver %s", modem->driver); if (driver_list[i].setup(modem) == TRUE) { ofono_modem_set_string(modem->modem, "SystemPath", syspath); ofono_modem_register(modem->modem); return FALSE; } + DBG("Modem setup failed, driver %s", modem->driver); } + DBG("Modem setup failed or not in driver_list?"); return TRUE; }