diff mbox series

[v3,8/8] ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used

Message ID 20181108073000.21114-9-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show
Series ASoC: omap-mcbsp: Cleanup and split core/sidetone support | expand

Commit Message

Peter Ujfalusi Nov. 8, 2018, 7:30 a.m. UTC
Initializing to -EINVAL is not correct as the variables are unsigned and
if buffer_size is 0 then they are not used anyway.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
---
 sound/soc/omap/omap-mcbsp.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 8cab1151d3bb..e0ef4774c710 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -727,9 +727,6 @@  static int omap_mcbsp_init(struct platform_device *pdev)
 				"Unable to create additional controls\n");
 			goto err_thres;
 		}
-	} else {
-		mcbsp->max_tx_thres = -EINVAL;
-		mcbsp->max_rx_thres = -EINVAL;
 	}
 
 	ret = omap_mcbsp_st_init(pdev);