| Message ID | 20190129073843.14979-1-andreas@kemnade.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm: dts: gta04: add gps support | expand |
On Tue, Jan 29, 2019 at 08:38:43AM +0100, Andreas Kemnade wrote: > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable > which one is mounted so use the compatibility entry for w2sg0004 > for all which will work for both. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > Changes in v2: > - some s/gps/gnss/ > - not added vcc-supply because the regulator is not modelled > in dts at all I strongly suggest not sending revised patches before people have a chance to comment on your previous version and resolve any issues that may have been raised. Also it is customary to CC anyone how bothers to help review your patches. Johan
On Wed, 30 Jan 2019 10:04:34 +0100 Johan Hovold <johan@kernel.org> wrote: > On Tue, Jan 29, 2019 at 08:38:43AM +0100, Andreas Kemnade wrote: > > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable > > which one is mounted so use the compatibility entry for w2sg0004 > > for all which will work for both. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > Changes in v2: > > - some s/gps/gnss/ > > - not added vcc-supply because the regulator is not modelled > > in dts at all > > I strongly suggest not sending revised patches before people have a > chance to comment on your previous version and resolve any issues that > may have been raised. for technical check there was already some small team review ahead, so I expect only formality issues and not something complicated and was not mentally prepared for more discussion. At that point I had the impression that I am not allowed to have such driverless things into dtb, so I had the impression that I have to follow two conflicting rules at the same time. That leads to the impression that I worked a long way into a dead end which made me quite angry so I was not as contructive as I should be. Regards, Andreas
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi index e53d32691308..d58c117e429f 100644 --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi @@ -312,6 +312,12 @@ >; }; + gps_pins: pinmux_gps_pins { + pinctrl-single,pins = < + OMAP3_CORE1_IOPAD(0x2176, PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* gpio145 */ + >; + }; + hdq_pins: hdq_pins { pinctrl-single,pins = < OMAP3_CORE1_IOPAD(0x21c6, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c3_sda.hdq */ @@ -644,6 +650,13 @@ &uart2 { pinctrl-names = "default"; pinctrl-0 = <&uart2_pins>; + gnss: gnss { + compatible = "wi2wi,w2sg0004"; + pinctrl-names = "default"; + pinctrl-0 = <&gps_pins>; + sirf,onoff-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; + lna-supply = <&vsim>; + }; }; &uart3 {
The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable which one is mounted so use the compatibility entry for w2sg0004 for all which will work for both. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- Changes in v2: - some s/gps/gnss/ - not added vcc-supply because the regulator is not modelled in dts at all w2sg0004 bindings are in next-20190129 https://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss gnss-next arch/arm/boot/dts/omap3-gta04.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)