| Message ID | 20190512100328.27136-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: ti: Remove unused function ti_clk_build_component_gate | expand |
On 12/05/2019 13:03, YueHaibing wrote: > There is no callers in tree, so can be removed. Looks ok to me, basically legacy code that we forgot to remove while doing: commit 7558562a70fbd6b3fa746fa33c76c9333aa0bb32 Author: Tony Lindgren <tony@atomide.com> Date: Thu Dec 14 08:32:06 2017 -0800 clk: ti: Drop legacy clk-3xxx-legacy code Could drop the same code for mux/div also though. -Tero > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/clk/ti/gate.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) > > diff --git a/drivers/clk/ti/gate.c b/drivers/clk/ti/gate.c > index 504c0e9..4238955 100644 > --- a/drivers/clk/ti/gate.c > +++ b/drivers/clk/ti/gate.c > @@ -131,36 +131,6 @@ static struct clk *_register_gate(struct device *dev, const char *name, > return clk; > } > > -struct clk_hw *ti_clk_build_component_gate(struct ti_clk_gate *setup) > -{ > - struct clk_hw_omap *gate; > - struct clk_omap_reg *reg; > - const struct clk_hw_omap_ops *ops = &clkhwops_wait; > - > - if (!setup) > - return NULL; > - > - gate = kzalloc(sizeof(*gate), GFP_KERNEL); > - if (!gate) > - return ERR_PTR(-ENOMEM); > - > - reg = (struct clk_omap_reg *)&gate->enable_reg; > - reg->index = setup->module; > - reg->offset = setup->reg; > - > - gate->enable_bit = setup->bit_shift; > - > - if (setup->flags & CLKF_NO_WAIT) > - ops = NULL; > - > - if (setup->flags & CLKF_INTERFACE) > - ops = &clkhwops_iclk_wait; > - > - gate->ops = ops; > - > - return &gate->hw; > -} > - > static void __init _of_ti_gate_clk_setup(struct device_node *node, > const struct clk_ops *ops, > const struct clk_hw_omap_ops *hw_ops) > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 2019/5/13 15:22, Tero Kristo wrote: > On 12/05/2019 13:03, YueHaibing wrote: >> There is no callers in tree, so can be removed. > > Looks ok to me, basically legacy code that we forgot to remove while doing: > > commit 7558562a70fbd6b3fa746fa33c76c9333aa0bb32 > Author: Tony Lindgren <tony@atomide.com> > Date: Thu Dec 14 08:32:06 2017 -0800 > > clk: ti: Drop legacy clk-3xxx-legacy code > > Could drop the same code for mux/div also though. Yes, I can send v2 also to remove this two, thanks! > > -Tero > >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/clk/ti/gate.c | 30 ------------------------------ >> 1 file changed, 30 deletions(-) >> >> diff --git a/drivers/clk/ti/gate.c b/drivers/clk/ti/gate.c >> index 504c0e9..4238955 100644 >> --- a/drivers/clk/ti/gate.c >> +++ b/drivers/clk/ti/gate.c >> @@ -131,36 +131,6 @@ static struct clk *_register_gate(struct device *dev, const char *name, >> return clk; >> } >> -struct clk_hw *ti_clk_build_component_gate(struct ti_clk_gate *setup) >> -{ >> - struct clk_hw_omap *gate; >> - struct clk_omap_reg *reg; >> - const struct clk_hw_omap_ops *ops = &clkhwops_wait; >> - >> - if (!setup) >> - return NULL; >> - >> - gate = kzalloc(sizeof(*gate), GFP_KERNEL); >> - if (!gate) >> - return ERR_PTR(-ENOMEM); >> - >> - reg = (struct clk_omap_reg *)&gate->enable_reg; >> - reg->index = setup->module; >> - reg->offset = setup->reg; >> - >> - gate->enable_bit = setup->bit_shift; >> - >> - if (setup->flags & CLKF_NO_WAIT) >> - ops = NULL; >> - >> - if (setup->flags & CLKF_INTERFACE) >> - ops = &clkhwops_iclk_wait; >> - >> - gate->ops = ops; >> - >> - return &gate->hw; >> -} >> - >> static void __init _of_ti_gate_clk_setup(struct device_node *node, >> const struct clk_ops *ops, >> const struct clk_hw_omap_ops *hw_ops) >> > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > . >
diff --git a/drivers/clk/ti/gate.c b/drivers/clk/ti/gate.c index 504c0e9..4238955 100644 --- a/drivers/clk/ti/gate.c +++ b/drivers/clk/ti/gate.c @@ -131,36 +131,6 @@ static struct clk *_register_gate(struct device *dev, const char *name, return clk; } -struct clk_hw *ti_clk_build_component_gate(struct ti_clk_gate *setup) -{ - struct clk_hw_omap *gate; - struct clk_omap_reg *reg; - const struct clk_hw_omap_ops *ops = &clkhwops_wait; - - if (!setup) - return NULL; - - gate = kzalloc(sizeof(*gate), GFP_KERNEL); - if (!gate) - return ERR_PTR(-ENOMEM); - - reg = (struct clk_omap_reg *)&gate->enable_reg; - reg->index = setup->module; - reg->offset = setup->reg; - - gate->enable_bit = setup->bit_shift; - - if (setup->flags & CLKF_NO_WAIT) - ops = NULL; - - if (setup->flags & CLKF_INTERFACE) - ops = &clkhwops_iclk_wait; - - gate->ops = ops; - - return &gate->hw; -} - static void __init _of_ti_gate_clk_setup(struct device_node *node, const struct clk_ops *ops, const struct clk_hw_omap_ops *hw_ops)
There is no callers in tree, so can be removed. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/clk/ti/gate.c | 30 ------------------------------ 1 file changed, 30 deletions(-)