| Message ID | 20190516043218.8222-4-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mfd: lp87565: Add support for 4-phase lp87561 combination | expand |
On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote: > The LP8756x family has a single output 4-phase regulator > configuration. Add support for the same. The control > lies in the master buck which is buck0 for 4-phase > configuration. Enable/disable/voltage set happen via > buck0 registers. Acked-by: Mark Brown <broonie@kernel.org>
On 22/05/19 9:05 PM, Mark Brown wrote: > On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote: >> The LP8756x family has a single output 4-phase regulator >> configuration. Add support for the same. The control >> lies in the master buck which is buck0 for 4-phase >> configuration. Enable/disable/voltage set happen via >> buck0 registers. > > Acked-by: Mark Brown <broonie@kernel.org> Mark/Lee, This patch will come via the mfd branch? - Keerthy >
On Tue, May 28, 2019 at 03:23:41PM +0530, Keerthy wrote: > On 22/05/19 9:05 PM, Mark Brown wrote: > > On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote: > > Acked-by: Mark Brown <broonie@kernel.org> > This patch will come via the mfd branch? I'd expect so, IIRC it had a build dependency on the earlier patches in the series so if that doesn't happen I'll need to merge the relevant MFD commits.
On 5/28/2019 6:57 PM, Mark Brown wrote: > On Tue, May 28, 2019 at 03:23:41PM +0530, Keerthy wrote: >> On 22/05/19 9:05 PM, Mark Brown wrote: >>> On Thu, May 16, 2019 at 10:02:18AM +0530, Keerthy wrote: > >>> Acked-by: Mark Brown <broonie@kernel.org> > >> This patch will come via the mfd branch? > > I'd expect so, IIRC it had a build dependency on the earlier patches in > the series so if that doesn't happen I'll need to merge the relevant MFD > commits. Mark, mfd patches are on linux-next already. Hope you can pull this one now that dependencies are met. - Keerthy >
On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote: > mfd patches are on linux-next already. Hope you can pull this one now that > dependencies are met. Someone will need to send me a copy of the patch, if I acked it I was expecting it to go in with the MFD changes.
On Sat, 08 Jun 2019, Mark Brown wrote: > On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote: > > > mfd patches are on linux-next already. Hope you can pull this one now that > > dependencies are met. > > Someone will need to send me a copy of the patch, if I acked it I was > expecting it to go in with the MFD changes. There is/was no need for that. Patches are built-time orthogonal.
On 10/06/19 11:18 AM, Lee Jones wrote: > On Sat, 08 Jun 2019, Mark Brown wrote: > >> On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote: >> >>> mfd patches are on linux-next already. Hope you can pull this one now that >>> dependencies are met. >> >> Someone will need to send me a copy of the patch, if I acked it I was >> expecting it to go in with the MFD changes. > > There is/was no need for that. Patches are built-time orthogonal. Sorry i am still not clear. Should i resend this patch? >
On Wed, 12 Jun 2019, Keerthy wrote: > > > On 10/06/19 11:18 AM, Lee Jones wrote: > > On Sat, 08 Jun 2019, Mark Brown wrote: > > > > > On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote: > > > > > > > mfd patches are on linux-next already. Hope you can pull this one now that > > > > dependencies are met. > > > > > > Someone will need to send me a copy of the patch, if I acked it I was > > > expecting it to go in with the MFD changes. > > > > There is/was no need for that. Patches are built-time orthogonal. > > Sorry i am still not clear. Should i resend this patch? Yes. It sounds like Mark no longer has the patch to apply.
diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c index 81eb4b890c0c..af00d1ffcf33 100644 --- a/drivers/regulator/lp87565-regulator.c +++ b/drivers/regulator/lp87565-regulator.c @@ -153,6 +153,12 @@ static const struct lp87565_regulator regulators[] = { LP87565_REG_BUCK2_CTRL_1, LP87565_BUCK_CTRL_1_EN, 3230, buck0_1_2_3_ranges, LP87565_REG_BUCK2_CTRL_2), + LP87565_REGULATOR("BUCK3210", LP87565_BUCK_3210, "buck3210", + lp87565_buck_ops, 256, LP87565_REG_BUCK0_VOUT, + LP87565_BUCK_VSET, LP87565_REG_BUCK0_CTRL_1, + LP87565_BUCK_CTRL_1_EN | + LP87565_BUCK_CTRL_1_FPWM_MP_0_2, 3230, + buck0_1_2_3_ranges, LP87565_REG_BUCK0_CTRL_2), }; static int lp87565_regulator_probe(struct platform_device *pdev) @@ -169,9 +175,18 @@ static int lp87565_regulator_probe(struct platform_device *pdev) config.driver_data = lp87565; config.regmap = lp87565->regmap; - if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) { + switch (lp87565->dev_type) { + case LP87565_DEVICE_TYPE_LP87565_Q1: min_idx = LP87565_BUCK_10; max_idx = LP87565_BUCK_23; + break; + case LP87565_DEVICE_TYPE_LP87561_Q1: + min_idx = LP87565_BUCK_3210; + max_idx = LP87565_BUCK_3210; + default: + dev_err(lp87565->dev, "Invalid lp config %d\n", + lp87565->dev_type); + return -EINVAL; } for (i = min_idx; i <= max_idx; i++) {
The LP8756x family has a single output 4-phase regulator configuration. Add support for the same. The control lies in the master buck which is buck0 for 4-phase configuration. Enable/disable/voltage set happen via buck0 registers. Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf Signed-off-by: Keerthy <j-keerthy@ti.com> --- Changes in v2: * Changed if/else block to switch statement. drivers/regulator/lp87565-regulator.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)