diff mbox series

[5/5] drm/panel: tpo-td043mtea1: Fix SPI alias

Message ID 20191007170801.27647-6-laurent.pinchart@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series Fix SPI module alias for panels used by omapdrm | expand

Commit Message

Laurent Pinchart Oct. 7, 2019, 5:08 p.m. UTC 
The panel-tpo-td043mtea1 driver incorrectly includes the OF vendor
prefix in its SPI alias. Fix it, and move the manual alias to an SPI
module device table.

Fixes: dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

H. Nikolaus Schaller Oct. 7, 2019, 7:34 p.m. UTC | #1 
> Am 07.10.2019 um 19:08 schrieb Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> 
> The panel-tpo-td043mtea1 driver incorrectly includes the OF vendor
> prefix in its SPI alias. Fix it, and move the manual alias to an SPI
> module device table.
> 
> Fixes: dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: H. Nikolaus Schaller <hns@goldelico.com> # OpenPandora

> ---
> drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> index 84370562910f..ba163c779084 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> @@ -491,9 +491,17 @@ static const struct of_device_id td043mtea1_of_match[] = {
> 
> MODULE_DEVICE_TABLE(of, td043mtea1_of_match);
> 
> +static const struct spi_device_id td043mtea1_ids[] = {
> +	{ "td043mtea1", 0 },
> +	{ /* sentinel */ }
> +};
> +
> +MODULE_DEVICE_TABLE(spi, td043mtea1_ids);
> +
> static struct spi_driver td043mtea1_driver = {
> 	.probe		= td043mtea1_probe,
> 	.remove		= td043mtea1_remove,
> +	.id_table	= td043mtea1_ids,
> 	.driver		= {
> 		.name	= "panel-tpo-td043mtea1",
> 		.pm	= &td043mtea1_pm_ops,
> @@ -503,7 +511,6 @@ static struct spi_driver td043mtea1_driver = {
> 
> module_spi_driver(td043mtea1_driver);
> 
> -MODULE_ALIAS("spi:tpo,td043mtea1");
> MODULE_AUTHOR("Gražvydas Ignotas <notasas@gmail.com>");
> MODULE_DESCRIPTION("TPO TD043MTEA1 Panel Driver");
> MODULE_LICENSE("GPL");
> -- 
> Regards,
> 
> Laurent Pinchart
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
index 84370562910f..ba163c779084 100644
--- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
+++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
@@ -491,9 +491,17 @@  static const struct of_device_id td043mtea1_of_match[] = {
 
 MODULE_DEVICE_TABLE(of, td043mtea1_of_match);
 
+static const struct spi_device_id td043mtea1_ids[] = {
+	{ "td043mtea1", 0 },
+	{ /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(spi, td043mtea1_ids);
+
 static struct spi_driver td043mtea1_driver = {
 	.probe		= td043mtea1_probe,
 	.remove		= td043mtea1_remove,
+	.id_table	= td043mtea1_ids,
 	.driver		= {
 		.name	= "panel-tpo-td043mtea1",
 		.pm	= &td043mtea1_pm_ops,
@@ -503,7 +511,6 @@  static struct spi_driver td043mtea1_driver = {
 
 module_spi_driver(td043mtea1_driver);
 
-MODULE_ALIAS("spi:tpo,td043mtea1");
 MODULE_AUTHOR("Gražvydas Ignotas <notasas@gmail.com>");
 MODULE_DESCRIPTION("TPO TD043MTEA1 Panel Driver");
 MODULE_LICENSE("GPL");