| Message ID | 20200605031940.27911-1-navid.emamdoost@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PCI: dwc: pci-dra7xx: handle failure case of pm_runtime_get_sync | expand |
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 3b0e58f2de58..83986f5f2be7 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -932,7 +932,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) ret = pm_runtime_get_sync(dev); if (ret < 0) { dev_err(dev, "pm_runtime_get_sync failed\n"); - goto err_get_sync; + goto err_gpio; } reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); @@ -1001,8 +1001,6 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) err_gpio: pm_runtime_put(dev); - -err_get_sync: pm_runtime_disable(dev); dra7xx_pcie_disable_phy(dra7xx);
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> --- drivers/pci/controller/dwc/pci-dra7xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)