| Message ID | 20200611220951.GA3355634@x1 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode | expand |
On 12/06/2020 01:09, Drew Fustini wrote: > Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for > RGMII mode") the networking is broken on the BeagleBone AI which has > the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from > phy-mode = "rgmii" to phy-mode = "rgmii-rxid". > > Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for > other AM5729 boards. commit ref is incorrect > > [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf > > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") Pls change fixed tag to 520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree as this board DTB was merged only in 5.8. > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > Signed-off-by: Drew Fustini <drew@beagleboard.org> > --- > arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts > index 9877d7709d41..4c51c6b05e64 100644 > --- a/arch/arm/boot/dts/am5729-beagleboneai.dts > +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts > @@ -505,7 +505,7 @@ &mac { > > &cpsw_emac0 { > phy-handle = <&phy0>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-rxid"; > }; > > &ocp { > Thanks, pls fix above and you can add my Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
On Mon, Jun 15, 2020 at 12:34:57PM +0300, Grygorii Strashko wrote: > > > On 12/06/2020 01:09, Drew Fustini wrote: > > Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for > > RGMII mode") the networking is broken on the BeagleBone AI which has > > the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from > > phy-mode = "rgmii" to phy-mode = "rgmii-rxid". > > > > Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for > > other AM5729 boards. > > commit ref is incorrect Do you mean commit ref 820f8a870f65 ? ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy") I thought it made sense to point to that commit as you seemed to be fixing a very similar issue, just for a different phy. Or did you mean commit ref cd28d1d6e52e ? ("net: phy: at803x: Disable phy delay for RGMII mode") I believe this is the commit that made it necessary to change the phy-mode property for the AR8035 PHY. > > > > [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf > > > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > > Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") > > Pls change fixed tag to > 520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree > as this board DTB was merged only in 5.8. Ok, will do. > > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > > Signed-off-by: Drew Fustini <drew@beagleboard.org> > > --- > > arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts > > index 9877d7709d41..4c51c6b05e64 100644 > > --- a/arch/arm/boot/dts/am5729-beagleboneai.dts > > +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts > > @@ -505,7 +505,7 @@ &mac { > > &cpsw_emac0 { > > phy-handle = <&phy0>; > > - phy-mode = "rgmii"; > > + phy-mode = "rgmii-rxid"; > > }; > > &ocp { > > > > Thanks, pls fix above and you can add my > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> > > -- > Best regards, > grygorii Thanks for taking the time to review. -Drew
On 15/06/2020 15:45, Drew Fustini wrote: > On Mon, Jun 15, 2020 at 12:34:57PM +0300, Grygorii Strashko wrote: >> >> >> On 12/06/2020 01:09, Drew Fustini wrote: >>> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for >>> RGMII mode") the networking is broken on the BeagleBone AI which has >>> the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from >>> phy-mode = "rgmii" to phy-mode = "rgmii-rxid". >>> >>> Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for >>> other AM5729 boards. >> >> commit ref is incorrect > > Do you mean commit ref 820f8a870f65 ? > ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy") > > I thought it made sense to point to that commit as you seemed to be > fixing a very similar issue, just for a different phy. Yes. but you should use proper format for commit ref: commit <12+ chars of sha1> (\"<title line>\")' checkpatch should warn you.
diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts index 9877d7709d41..4c51c6b05e64 100644 --- a/arch/arm/boot/dts/am5729-beagleboneai.dts +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts @@ -505,7 +505,7 @@ &mac { &cpsw_emac0 { phy-handle = <&phy0>; - phy-mode = "rgmii"; + phy-mode = "rgmii-rxid"; }; &ocp {
Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid". Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for other AM5729 boards. [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf Cc: Vinod Koul <vkoul@kernel.org> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") Signed-off-by: Robert Nelson <robertcnelson@gmail.com> Signed-off-by: Drew Fustini <drew@beagleboard.org> --- arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)