| Message ID | 20200826125919.22172-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] memory: omap-gpmc: Fix build error without CONFIG_OF | expand |
Hi, On 26/08/2020 15:59, YueHaibing wrote: > If CONFIG_OF is n, gcc fails: > > drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': > omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' > > Add gpmc_read_settings_dt() helper function to fix this. > > Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: add gpmc_read_settings_dt() stub > --- > drivers/memory/omap-gpmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index cd9e80748591..02c0c694ecaf 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2310,6 +2310,9 @@ static void gpmc_probe_dt_children(struct platform_device *pdev) > } > } > #else > +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p) > +{ I will suggest to set gpmc_settings data structure to zero here so that the caller doesn't proceed with random/invalid settings. > +} > static int gpmc_probe_dt(struct platform_device *pdev) > { > return 0; > cheers, -roger
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index cd9e80748591..02c0c694ecaf 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2310,6 +2310,9 @@ static void gpmc_probe_dt_children(struct platform_device *pdev) } } #else +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p) +{ +} static int gpmc_probe_dt(struct platform_device *pdev) { return 0;
If CONFIG_OF is n, gcc fails: drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' Add gpmc_read_settings_dt() helper function to fix this. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: add gpmc_read_settings_dt() stub --- drivers/memory/omap-gpmc.c | 3 +++ 1 file changed, 3 insertions(+)