diff mbox series

ARM: OMAP2+: Remove redundant assignment to variable ret

Message ID 20200919034331.161271-1-jingxiangfeng@huawei.com (mailing list archive)
State New, archived
Headers show
Series ARM: OMAP2+: Remove redundant assignment to variable ret | expand

Commit Message

Jing Xiangfeng Sept. 19, 2020, 3:43 a.m. UTC 
The variable ret has been initialized with '-ENOMEM'. The assignment
in the if branch is redundant. So remove it.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 arch/arm/mach-omap2/omap_device.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Tony Lindgren Nov. 19, 2020, 9:53 a.m. UTC | #1 
* Jing Xiangfeng <jingxiangfeng@huawei.com> [200919 06:43]:
> The variable ret has been initialized with '-ENOMEM'. The assignment
> in the if branch is redundant. So remove it.

Thanks applying into omap-for-v5.11/soc.

Tony
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index fc7bb2ca1672..f3191704cab9 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -334,10 +334,9 @@  struct omap_device *omap_device_alloc(struct platform_device *pdev,
 	struct omap_hwmod **hwmods;
 
 	od = kzalloc(sizeof(struct omap_device), GFP_KERNEL);
-	if (!od) {
-		ret = -ENOMEM;
+	if (!od)
 		goto oda_exit1;
-	}
+
 	od->hwmods_cnt = oh_cnt;
 
 	hwmods = kmemdup(ohs, sizeof(struct omap_hwmod *) * oh_cnt, GFP_KERNEL);