| Message ID | 20200921205016.20461-16-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand |
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mfd/max77686.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 71faf503844b..1f26d00fdd37 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -217,8 +217,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c) > return ret; > } > > - ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL, > - 0, NULL); > + ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells, > + n_devs, NULL, 0, NULL); > if (ret < 0) { > dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret); > return ret; > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 71faf503844b..1f26d00fdd37 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -217,8 +217,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c) return ret; } - ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL, - 0, NULL); + ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells, + n_devs, NULL, 0, NULL); if (ret < 0) { dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret); return ret;
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)