diff mbox series

[24/42] mfd: rdc321x: use PLATFORM_DEVID_NONE

Message ID 20200921205016.20461-24-krzk@kernel.org (mailing list archive)
State New, archived
Headers show
Series [01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC 
Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/rdc321x-southbridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Sept. 21, 2020, 9:12 p.m. UTC | #1 
On 9/21/20 1:49 PM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff mbox series

Patch

diff --git a/drivers/mfd/rdc321x-southbridge.c b/drivers/mfd/rdc321x-southbridge.c
index fbb1faf95e27..6fb0d625cec9 100644
--- a/drivers/mfd/rdc321x-southbridge.c
+++ b/drivers/mfd/rdc321x-southbridge.c
@@ -71,7 +71,7 @@  static int rdc321x_sb_probe(struct pci_dev *pdev,
 	rdc321x_gpio_pdata.sb_pdev = pdev;
 	rdc321x_wdt_pdata.sb_pdev = pdev;
 
-	return devm_mfd_add_devices(&pdev->dev, -1,
+	return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
 				    rdc321x_sb_cells,
 				    ARRAY_SIZE(rdc321x_sb_cells),
 				    NULL, 0, NULL);