| Message ID | 20210401162032.10150-1-maciej.falkowski9@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: isp1301-omap: Add missing gpiod_add_lookup_table function | expand |
On Thu, Apr 1, 2021 at 9:21 AM Maciej Falkowski <maciej.falkowski9@gmail.com> wrote: > > The gpiod table was added without any usage making it unused > as reported by Clang compilation from omap1_defconfig on linux-next: > > arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable 'isp1301_gpiod_table' [-Wunused-variable] > static struct gpiod_lookup_table isp1301_gpiod_table = { > ^ > 1 warning generated. > > The patch adds the missing gpiod_add_lookup_table() function. > > Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com> > Fixes: f3ef38160e3d ("usb: isp1301-omap: Convert to use GPIO descriptors") > Link: https://github.com/ClangBuiltLinux/linux/issues/1325 Looks consistent to me with other callers of gpiod_add_lookup_table from .init_machine callbacks. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/arm/mach-omap1/board-h2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c > index c40cf5ef8607..977b0b744c22 100644 > --- a/arch/arm/mach-omap1/board-h2.c > +++ b/arch/arm/mach-omap1/board-h2.c > @@ -320,7 +320,7 @@ static int tps_setup(struct i2c_client *client, void *context) > { > if (!IS_BUILTIN(CONFIG_TPS65010)) > return -ENOSYS; > - > + > tps65010_config_vregs1(TPS_LDO2_ENABLE | TPS_VLDO2_3_0V | > TPS_LDO1_ENABLE | TPS_VLDO1_3_0V); > > @@ -394,6 +394,8 @@ static void __init h2_init(void) > BUG_ON(gpio_request(H2_NAND_RB_GPIO_PIN, "NAND ready") < 0); > gpio_direction_input(H2_NAND_RB_GPIO_PIN); > > + gpiod_add_lookup_table(&isp1301_gpiod_table); > + > omap_cfg_reg(L3_1610_FLASH_CS2B_OE); > omap_cfg_reg(M8_1610_FLASH_CS2B_WE); > > --
* Maciej Falkowski <maciej.falkowski9@gmail.com> [210401 19:22]: > The gpiod table was added without any usage making it unused > as reported by Clang compilation from omap1_defconfig on linux-next: > > arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable 'isp1301_gpiod_table' [-Wunused-variable] > static struct gpiod_lookup_table isp1301_gpiod_table = { > ^ > 1 warning generated. > > The patch adds the missing gpiod_add_lookup_table() function. Applying into fixes thanks. Tony
diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c index c40cf5ef8607..977b0b744c22 100644 --- a/arch/arm/mach-omap1/board-h2.c +++ b/arch/arm/mach-omap1/board-h2.c @@ -320,7 +320,7 @@ static int tps_setup(struct i2c_client *client, void *context) { if (!IS_BUILTIN(CONFIG_TPS65010)) return -ENOSYS; - + tps65010_config_vregs1(TPS_LDO2_ENABLE | TPS_VLDO2_3_0V | TPS_LDO1_ENABLE | TPS_VLDO1_3_0V); @@ -394,6 +394,8 @@ static void __init h2_init(void) BUG_ON(gpio_request(H2_NAND_RB_GPIO_PIN, "NAND ready") < 0); gpio_direction_input(H2_NAND_RB_GPIO_PIN); + gpiod_add_lookup_table(&isp1301_gpiod_table); + omap_cfg_reg(L3_1610_FLASH_CS2B_OE); omap_cfg_reg(M8_1610_FLASH_CS2B_WE);
The gpiod table was added without any usage making it unused as reported by Clang compilation from omap1_defconfig on linux-next: arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable 'isp1301_gpiod_table' [-Wunused-variable] static struct gpiod_lookup_table isp1301_gpiod_table = { ^ 1 warning generated. The patch adds the missing gpiod_add_lookup_table() function. Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com> Fixes: f3ef38160e3d ("usb: isp1301-omap: Convert to use GPIO descriptors") Link: https://github.com/ClangBuiltLinux/linux/issues/1325 --- arch/arm/mach-omap1/board-h2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)