| Message ID | 20210928133143.157329-26-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | TI AM437X ADC1 | expand |
On Tue, 28 Sep 2021 15:31:20 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Before adding another frequency with even more zeroes, use the > HZ_PER_MHZ macro to clarify the number. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> You missed tag I gave on v3. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Thanks, > --- > include/linux/mfd/ti_am335x_tscadc.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h > index 893c474c1f8c..a85643677bef 100644 > --- a/include/linux/mfd/ti_am335x_tscadc.h > +++ b/include/linux/mfd/ti_am335x_tscadc.h > @@ -9,6 +9,7 @@ > #define __LINUX_TI_AM335X_TSCADC_MFD_H > > #include <linux/mfd/core.h> > +#include <linux/units.h> > > #define REG_RAWIRQSTATUS 0x024 > #define REG_IRQSTATUS 0x028 > @@ -133,7 +134,7 @@ > #define SEQ_STATUS BIT(5) > #define CHARGE_STEP 0x11 > > -#define ADC_CLK 3000000 > +#define ADC_CLK (3 * HZ_PER_MHZ) > #define TOTAL_STEPS 16 > #define TOTAL_CHANNELS 8 > #define FIFO1_THRESHOLD 19
Hi Jonathan, jic23@kernel.org wrote on Wed, 29 Sep 2021 16:29:05 +0100: > On Tue, 28 Sep 2021 15:31:20 +0200 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > Before adding another frequency with even more zeroes, use the > > HZ_PER_MHZ macro to clarify the number. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > You missed tag I gave on v3. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Oh right, sorry about that. Cheers, Miquèl
diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h index 893c474c1f8c..a85643677bef 100644 --- a/include/linux/mfd/ti_am335x_tscadc.h +++ b/include/linux/mfd/ti_am335x_tscadc.h @@ -9,6 +9,7 @@ #define __LINUX_TI_AM335X_TSCADC_MFD_H #include <linux/mfd/core.h> +#include <linux/units.h> #define REG_RAWIRQSTATUS 0x024 #define REG_IRQSTATUS 0x028 @@ -133,7 +134,7 @@ #define SEQ_STATUS BIT(5) #define CHARGE_STEP 0x11 -#define ADC_CLK 3000000 +#define ADC_CLK (3 * HZ_PER_MHZ) #define TOTAL_STEPS 16 #define TOTAL_CHANNELS 8 #define FIFO1_THRESHOLD 19
Before adding another frequency with even more zeroes, use the HZ_PER_MHZ macro to clarify the number. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- include/linux/mfd/ti_am335x_tscadc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)