diff mbox series

[1/5] dt-bindings: sdhci-omap: Update binding for legacy SoCs

Message ID 20210930065733.31943-2-tony@atomide.com (mailing list archive)
State New, archived
Headers show
Series More SoCs for sdhci-omap to deprecate omap_hsmmc | expand

Commit Message

Tony Lindgren Sept. 30, 2021, 6:57 a.m. UTC 
Let's add compatible values for the legacy SoCs so we can continue
deprecating omap_hsmmc in favor of sdhci-omap driver.

For omap5, we want to have a separate compatible from omap4 for the
additional features available on omap5. AFAIK ti81 can just use the
omap4 compatible.

Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Adam Ford Oct. 2, 2021, 1:29 p.m. UTC | #1 
On Thu, Sep 30, 2021 at 1:58 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Let's add compatible values for the legacy SoCs so we can continue
> deprecating omap_hsmmc in favor of sdhci-omap driver.
>
> For omap5, we want to have a separate compatible from omap4 for the
> additional features available on omap5. AFAIK ti81 can just use the
> omap4 compatible.
>
> Cc: devicetree@vger.kernel.org
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Tony,

I noticed that you added omap3 compatibility to the driver and the
bindings, but no device tree changes for omap3.dtsi to enable this.
Is there anything holding back?

I modified omap3.dtsi and changed the compatible flag to
ti,omap3-sdhci and it boots from SD card just fine.  For some reason,
I cannot get the wl1283 to function, but the driver probes, so I need
to spend some time investigating this.

If i can get my wl1283 working again, I'll reply with a tested note.
I hope to have more time tomorrow, but i can't do it any more today.

adam

> ---
>  Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> @@ -5,7 +5,11 @@ Refer to mmc.txt for standard MMC bindings.
>  For UHS devices which require tuning, the device tree should have a "cpu_thermal" node which maps to the appropriate thermal zone. This is used to get the temperature of the zone during tuning.
>
>  Required properties:
> -- compatible: Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
> +- compatible: Should be "ti,omap2430-sdhci" for omap2430 controllers
> +             Should be "ti,omap3-sdhci" for omap3 controllers
> +             Should be "ti,omap4-sdhci" for omap4 and ti81 controllers
> +             Should be "ti,omap5-sdhci" for omap5 controllers
> +             Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
>               Should be "ti,k2g-sdhci" for K2G
>               Should be "ti,am335-sdhci" for am335x controllers
>               Should be "ti,am437-sdhci" for am437x controllers
> --
> 2.33.0
Adam Ford Oct. 2, 2021, 4:15 p.m. UTC | #2 
On Thu, Sep 30, 2021 at 1:58 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Let's add compatible values for the legacy SoCs so we can continue
> deprecating omap_hsmmc in favor of sdhci-omap driver.
>
> For omap5, we want to have a separate compatible from omap4 for the
> additional features available on omap5. AFAIK ti81 can just use the
> omap4 compatible.
>
> Cc: devicetree@vger.kernel.org
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

For the series, with an additional change to omap3.dtsi to reference
mmc nodes to ti,omap3-sdhci,

Tested-by: Adam Ford <aford173@gmail.com> # logicpd-torpedo-37xx-devkit

> ---
>  Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> @@ -5,7 +5,11 @@ Refer to mmc.txt for standard MMC bindings.
>  For UHS devices which require tuning, the device tree should have a "cpu_thermal" node which maps to the appropriate thermal zone. This is used to get the temperature of the zone during tuning.
>
>  Required properties:
> -- compatible: Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
> +- compatible: Should be "ti,omap2430-sdhci" for omap2430 controllers
> +             Should be "ti,omap3-sdhci" for omap3 controllers
> +             Should be "ti,omap4-sdhci" for omap4 and ti81 controllers
> +             Should be "ti,omap5-sdhci" for omap5 controllers
> +             Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
>               Should be "ti,k2g-sdhci" for K2G
>               Should be "ti,am335-sdhci" for am335x controllers
>               Should be "ti,am437-sdhci" for am437x controllers
> --
> 2.33.0
Tony Lindgren Oct. 5, 2021, 8:04 a.m. UTC | #3 
Hi,

* Adam Ford <aford173@gmail.com> [211002 13:29]:
> I noticed that you added omap3 compatibility to the driver and the
> bindings, but no device tree changes for omap3.dtsi to enable this.
> Is there anything holding back?

There is at least the wl1251 quirk handling missing as I mentioned in
the cover letter. I guess we could enable sdhci except for wl1251 users
though.

> I modified omap3.dtsi and changed the compatible flag to
> ti,omap3-sdhci and it boots from SD card just fine.  For some reason,
> I cannot get the wl1283 to function, but the driver probes, so I need
> to spend some time investigating this.
> 
> If i can get my wl1283 working again, I'll reply with a tested note.
> I hope to have more time tomorrow, but i can't do it any more today.

I don't have wl1283 omap3 devices online, but I have tested that the
sdhci patches do work with wl12xx and mwifiex drivers. Did you figure
out why your wl1283 is not working with sdhci?

Regards,

Tony
Adam Ford Oct. 5, 2021, 10:45 a.m. UTC | #4 
On Tue, Oct 5, 2021 at 3:04 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Hi,
>
> * Adam Ford <aford173@gmail.com> [211002 13:29]:
> > I noticed that you added omap3 compatibility to the driver and the
> > bindings, but no device tree changes for omap3.dtsi to enable this.
> > Is there anything holding back?
>
> There is at least the wl1251 quirk handling missing as I mentioned in
> the cover letter. I guess we could enable sdhci except for wl1251 users
> though.

Sorry, I guess I missed the cover letter.  I didn't see any obvious
differences between the drivers other than the hsmmc driver enumerated
before the DMA, so it threw some splat indicating that.  The newer
driver appears to enumerate after the DMA, so that message
disappeared.

>
> > I modified omap3.dtsi and changed the compatible flag to
> > ti,omap3-sdhci and it boots from SD card just fine.  For some reason,
> > I cannot get the wl1283 to function, but the driver probes, so I need
> > to spend some time investigating this.
> >
> > If i can get my wl1283 working again, I'll reply with a tested note.
> > I hope to have more time tomorrow, but i can't do it any more today.
>
> I don't have wl1283 omap3 devices online, but I have tested that the
> sdhci patches do work with wl12xx and mwifiex drivers. Did you figure
> out why your wl1283 is not working with sdhci?

I did get it working.  It was a MAC address issue.  I didn't properly
set the MAC address.  Once I did, it worked just fine.

I think I sent a 2nd reply with a tested-by message.

adam
>
> Regards,
>
> Tony
Tony Lindgren Oct. 6, 2021, 5:03 a.m. UTC | #5 
* Adam Ford <aford173@gmail.com> [211005 10:46]:
> On Tue, Oct 5, 2021 at 3:04 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Adam Ford <aford173@gmail.com> [211002 13:29]:
> > > I noticed that you added omap3 compatibility to the driver and the
> > > bindings, but no device tree changes for omap3.dtsi to enable this.
> > > Is there anything holding back?
> >
> > There is at least the wl1251 quirk handling missing as I mentioned in
> > the cover letter. I guess we could enable sdhci except for wl1251 users
> > though.
> 
> Sorry, I guess I missed the cover letter.  I didn't see any obvious
> differences between the drivers other than the hsmmc driver enumerated
> before the DMA, so it threw some splat indicating that.  The newer
> driver appears to enumerate after the DMA, so that message
> disappeared.

OK

> > > I modified omap3.dtsi and changed the compatible flag to
> > > ti,omap3-sdhci and it boots from SD card just fine.  For some reason,
> > > I cannot get the wl1283 to function, but the driver probes, so I need
> > > to spend some time investigating this.
> > >
> > > If i can get my wl1283 working again, I'll reply with a tested note.
> > > I hope to have more time tomorrow, but i can't do it any more today.
> >
> > I don't have wl1283 omap3 devices online, but I have tested that the
> > sdhci patches do work with wl12xx and mwifiex drivers. Did you figure
> > out why your wl1283 is not working with sdhci?
> 
> I did get it working.  It was a MAC address issue.  I didn't properly
> set the MAC address.  Once I did, it worked just fine.
> 
> I think I sent a 2nd reply with a tested-by message.

OK good to hear, thanks for testing :)

Regards,

Tony
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
--- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
@@ -5,7 +5,11 @@  Refer to mmc.txt for standard MMC bindings.
 For UHS devices which require tuning, the device tree should have a "cpu_thermal" node which maps to the appropriate thermal zone. This is used to get the temperature of the zone during tuning.
 
 Required properties:
-- compatible: Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
+- compatible: Should be "ti,omap2430-sdhci" for omap2430 controllers
+	      Should be "ti,omap3-sdhci" for omap3 controllers
+	      Should be "ti,omap4-sdhci" for omap4 and ti81 controllers
+	      Should be "ti,omap5-sdhci" for omap5 controllers
+	      Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
 	      Should be "ti,k2g-sdhci" for K2G
 	      Should be "ti,am335-sdhci" for am335x controllers
 	      Should be "ti,am437-sdhci" for am437x controllers