| Message ID | 20220216074927.3619425-6-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | document dt-schema and fix node names for some USB Ethernet controllers | expand |
On 16/02/2022 08:49, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- > arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- > arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > Hi Oleksij, Both Exynos patches look good, unfortunately I forgot about them a week ago when I was preparing late pull request and now it is too late for this cycle. I will pick them up after the merge window. Sorry, for this. Best regards, Krzysztof
On Tue, Mar 08, 2022 at 12:02:29PM +0100, Krzysztof Kozlowski wrote: > On 16/02/2022 08:49, Oleksij Rempel wrote: > > The node name of Ethernet controller should be "ethernet" instead of > > "usbether" as required by Ethernet controller devicetree schema: > > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > > > This patch can potentially affect boot loaders patching against full > > node path instead of using device aliases. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- > > arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- > > arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +- > > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- > > 5 files changed, 5 insertions(+), 5 deletions(-) > > > > Hi Oleksij, > > Both Exynos patches look good, unfortunately I forgot about them a week > ago when I was preparing late pull request and now it is too late for > this cycle. I will pick them up after the merge window. Sorry, for this. No problem. Thank you for the feedback :) Regards, Oleksij
On Wed, 16 Feb 2022 08:49:23 +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > [...] Applied, thanks! [5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards commit: c1ed0f41032f54e47c03088f096f8b37cae40d8e Best regards,
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts index efaf7533e84f..5ddbb6cbe1bf 100644 --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts @@ -119,7 +119,7 @@ &ehci { phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>; phy-names = "hsic0", "hsic1"; - ethernet: usbether@2 { + ethernet: ethernet@2 { compatible = "usb0424,9730"; reg = <2>; local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts index 440135d0ff2a..ea7bccec518d 100644 --- a/arch/arm/boot/dts/exynos4412-odroidx.dts +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts @@ -81,7 +81,7 @@ hub@1 { #address-cells = <1>; #size-cells = <0>; - ethernet: usbether@1 { + ethernet: ethernet@1 { compatible = "usb0424,ec00"; reg = <1>; /* Filled in by a bootloader */ diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index 884fef55836c..38e23b4ae730 100644 --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts @@ -675,7 +675,7 @@ &usbhost2 { #address-cells = <1>; #size-cells = <0>; - ethernet: usbether@2 { + ethernet: ethernet@2 { compatible = "usb0424,9730"; reg = <2>; local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts index 62c5928aa994..749f051ffe70 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts @@ -118,7 +118,7 @@ hub@1 { #address-cells = <1>; #size-cells = <0>; - ethernet: usbether@1 { + ethernet: ethernet@1 { compatible = "usb0424,ec00"; reg = <1>; local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index cecaeb69e623..8cf3d644a4c1 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -85,7 +85,7 @@ hub@1 { #address-cells = <1>; #size-cells = <0>; - ethernet: usbether@1 { + ethernet: ethernet@1 { compatible = "usb0424,ec00"; reg = <1>; local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
The node name of Ethernet controller should be "ethernet" instead of "usbether" as required by Ethernet controller devicetree schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml This patch can potentially affect boot loaders patching against full node path instead of using device aliases. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)