| Message ID | 20220307123816.31888-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | omapfb: Add missing of_node_put() in dvic_probe_of | expand |
On 3/7/22 13:38, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> applied to the fbdev for-next tree. Thanks! Helge > --- > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > index 2fa436475b40..c8ad3ef42bd3 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > @@ -246,6 +246,7 @@ static int dvic_probe_of(struct platform_device *pdev) > adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0); > if (adapter_node) { > adapter = of_get_i2c_adapter_by_node(adapter_node); > + of_node_put(adapter_node); > if (adapter == NULL) { > dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n"); > omap_dss_put_device(ddata->in);
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c index 2fa436475b40..c8ad3ef42bd3 100644 --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c @@ -246,6 +246,7 @@ static int dvic_probe_of(struct platform_device *pdev) adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0); if (adapter_node) { adapter = of_get_i2c_adapter_by_node(adapter_node); + of_node_put(adapter_node); if (adapter == NULL) { dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n"); omap_dss_put_device(ddata->in);
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 + 1 file changed, 1 insertion(+)