| Message ID | 20220407225107.2175958-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: Fix more boolean properties with values | expand |
On 08.04.2022 01:51, Rob Herring wrote: > Boolean properties in DT are present or not present and don't take a value. > A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't > matter. > > It may have been intended that 0 values are false, but there is no change > in behavior with this patch. > > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: "Benoît Cousson" <bcousson@baylibre.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm/boot/dts/at91-sam9_l9260.dts | 2 +- For this one: Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> > arch/arm/boot/dts/imx28-ts4600.dts | 2 +- > arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++-- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 ++++---- > 4 files changed, 8 insertions(+), 8 deletions(-) >
On Thu 07 Apr 17:51 CDT 2022, Rob Herring wrote: > Boolean properties in DT are present or not present and don't take a value. > A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't > matter. > > It may have been intended that 0 values are false, but there is no change > in behavior with this patch. > > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: "Benoît Cousson" <bcousson@baylibre.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm/boot/dts/at91-sam9_l9260.dts | 2 +- > arch/arm/boot/dts/imx28-ts4600.dts | 2 +- > arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++-- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 ++++---- Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts > index 1e2a28c2f365..2fb51b9aca2a 100644 > --- a/arch/arm/boot/dts/at91-sam9_l9260.dts > +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts > @@ -101,7 +101,7 @@ pinctrl_board_mmc0: mmc0-board { > nand0: nand@40000000 { > nand-bus-width = <8>; > nand-ecc-mode = "soft"; > - nand-on-flash-bbt = <1>; > + nand-on-flash-bbt; > status = "okay"; > }; > > diff --git a/arch/arm/boot/dts/imx28-ts4600.dts b/arch/arm/boot/dts/imx28-ts4600.dts > index 097ec35c62d8..0d58da1c0cc5 100644 > --- a/arch/arm/boot/dts/imx28-ts4600.dts > +++ b/arch/arm/boot/dts/imx28-ts4600.dts > @@ -26,7 +26,7 @@ ssp0: spi@80010000 { > pinctrl-0 = <&mmc0_4bit_pins_a > &mmc0_sck_cfg > &en_sd_pwr>; > - broken-cd = <1>; > + broken-cd; > bus-width = <4>; > vmmc-supply = <®_vddio_sd0>; > status = "okay"; > diff --git a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi > index b4664ab00256..d3da8b1b473b 100644 > --- a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi > +++ b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi > @@ -118,8 +118,8 @@ usb@6,0 { > gpmc,device-width = <2>; > gpmc,wait-pin = <0>; > gpmc,burst-length = <4>; > - gpmc,cycle2cycle-samecsen = <1>; > - gpmc,cycle2cycle-diffcsen = <1>; > + gpmc,cycle2cycle-samecsen; > + gpmc,cycle2cycle-diffcsen; > gpmc,cs-on-ns = <0>; > gpmc,cs-rd-off-ns = <45>; > gpmc,cs-wr-off-ns = <45>; > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 996f4458d9fc..8cb04aa8ed2f 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -972,7 +972,7 @@ gmac0: ethernet@37000000 { > > snps,axi-config = <&stmmac_axi_setup>; > snps,pbl = <32>; > - snps,aal = <1>; > + snps,aal; > > qcom,nss-common = <&nss_common>; > qcom,qsgmii-csr = <&qsgmii_csr>; > @@ -996,7 +996,7 @@ gmac1: ethernet@37200000 { > > snps,axi-config = <&stmmac_axi_setup>; > snps,pbl = <32>; > - snps,aal = <1>; > + snps,aal; > > qcom,nss-common = <&nss_common>; > qcom,qsgmii-csr = <&qsgmii_csr>; > @@ -1020,7 +1020,7 @@ gmac2: ethernet@37400000 { > > snps,axi-config = <&stmmac_axi_setup>; > snps,pbl = <32>; > - snps,aal = <1>; > + snps,aal; > > qcom,nss-common = <&nss_common>; > qcom,qsgmii-csr = <&qsgmii_csr>; > @@ -1044,7 +1044,7 @@ gmac3: ethernet@37600000 { > > snps,axi-config = <&stmmac_axi_setup>; > snps,pbl = <32>; > - snps,aal = <1>; > + snps,aal; > > qcom,nss-common = <&nss_common>; > qcom,qsgmii-csr = <&qsgmii_csr>; > -- > 2.32.0 >
diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts index 1e2a28c2f365..2fb51b9aca2a 100644 --- a/arch/arm/boot/dts/at91-sam9_l9260.dts +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts @@ -101,7 +101,7 @@ pinctrl_board_mmc0: mmc0-board { nand0: nand@40000000 { nand-bus-width = <8>; nand-ecc-mode = "soft"; - nand-on-flash-bbt = <1>; + nand-on-flash-bbt; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx28-ts4600.dts b/arch/arm/boot/dts/imx28-ts4600.dts index 097ec35c62d8..0d58da1c0cc5 100644 --- a/arch/arm/boot/dts/imx28-ts4600.dts +++ b/arch/arm/boot/dts/imx28-ts4600.dts @@ -26,7 +26,7 @@ ssp0: spi@80010000 { pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_sck_cfg &en_sd_pwr>; - broken-cd = <1>; + broken-cd; bus-width = <4>; vmmc-supply = <®_vddio_sd0>; status = "okay"; diff --git a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi index b4664ab00256..d3da8b1b473b 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi +++ b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi @@ -118,8 +118,8 @@ usb@6,0 { gpmc,device-width = <2>; gpmc,wait-pin = <0>; gpmc,burst-length = <4>; - gpmc,cycle2cycle-samecsen = <1>; - gpmc,cycle2cycle-diffcsen = <1>; + gpmc,cycle2cycle-samecsen; + gpmc,cycle2cycle-diffcsen; gpmc,cs-on-ns = <0>; gpmc,cs-rd-off-ns = <45>; gpmc,cs-wr-off-ns = <45>; diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi index 996f4458d9fc..8cb04aa8ed2f 100644 --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi @@ -972,7 +972,7 @@ gmac0: ethernet@37000000 { snps,axi-config = <&stmmac_axi_setup>; snps,pbl = <32>; - snps,aal = <1>; + snps,aal; qcom,nss-common = <&nss_common>; qcom,qsgmii-csr = <&qsgmii_csr>; @@ -996,7 +996,7 @@ gmac1: ethernet@37200000 { snps,axi-config = <&stmmac_axi_setup>; snps,pbl = <32>; - snps,aal = <1>; + snps,aal; qcom,nss-common = <&nss_common>; qcom,qsgmii-csr = <&qsgmii_csr>; @@ -1020,7 +1020,7 @@ gmac2: ethernet@37400000 { snps,axi-config = <&stmmac_axi_setup>; snps,pbl = <32>; - snps,aal = <1>; + snps,aal; qcom,nss-common = <&nss_common>; qcom,qsgmii-csr = <&qsgmii_csr>; @@ -1044,7 +1044,7 @@ gmac3: ethernet@37600000 { snps,axi-config = <&stmmac_axi_setup>; snps,pbl = <32>; - snps,aal = <1>; + snps,aal; qcom,nss-common = <&nss_common>; qcom,qsgmii-csr = <&qsgmii_csr>;
Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter. It may have been intended that 0 values are false, but there is no change in behavior with this patch. Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: "Benoît Cousson" <bcousson@baylibre.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm/boot/dts/at91-sam9_l9260.dts | 2 +- arch/arm/boot/dts/imx28-ts4600.dts | 2 +- arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 4 ++-- arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-)