From patchwork Wed Jul 26 03:59:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13327420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949C4C04A94 for ; Wed, 26 Jul 2023 04:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjGZEBa (ORCPT ); Wed, 26 Jul 2023 00:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbjGZEBY (ORCPT ); Wed, 26 Jul 2023 00:01:24 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909B91BF2; Tue, 25 Jul 2023 21:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emaD7xU43pIwn2+JlF6P9d4QPBlkwx68rAJXSJVnrZzBaVjWo+XLr7UJe+7z6JzgS/v6xwuqrF94j70be5YR/eT/g5DW0BD4qUscbhwxKTPoAxNYxQ33ihG3HXOmXoEDlK92bFQsZY0yxLgucRPcFqoF/0EH253bygkiBJ2nSef3Vrb3y9J4CWWZhEGzuAbOHyQyZ+3oWnCId0p60V/N3oke96tzRFpihiM9m6ge+CjcCWr3//3/j8xdbmXM+Y4n9XLEZPKjln5DgMJh6PU0a/tLDeyTehiSd/zL0rqPt3VP1WNvS8CAVMT/x/K9WUyEtHALOAxaolfnDTy5q+knTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mjvydvAOnf9fdqZRVZUVRLRXIIaoxUyvKCR2No+4ygk=; b=Jmzzn4oAvglzBUVChj2gvNcdPRy1JmYiqzQUAVmi9PtJGCD1Lz3x7EAnLCZDRJ5gLNk1UR0dc1t6NcfX3dPsCdOcWHcU6yczbNNAeSohdLGwQGPNB+s+lxFsiKxBJRNmkPxHGZR5qgtG8dImhKhfLl6xNbk3d/m9q/qCxayJwnRmo7cWJLAxKl3jLq2h3c3rF0Tzl5ir4feoYuPrWknHyyrrdyRyqa/OsAFnk2Mt7n7e+dJnnbQ5YB6jttCzm8YmQv/nrE49X87RapS6TlYqK9ABmBFjvLX8jZod0DzXIwsDLW9CLqvkI1lt4SZGbdi+s4tfMTVxaVNdtXDPySleRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjvydvAOnf9fdqZRVZUVRLRXIIaoxUyvKCR2No+4ygk=; b=Re1h/w6VxQcwZ5ZGuwNZWeiYxlX9BmOkWMgMyl2NPvPHMtEaYEg8KO+6TaGm1A8wSNhNwlSxwoKOCzDeOvMHKI7WZG/4EHVI/WHjk5fdtFI6Ih3uabio7qOVtCkQIXPX7LfXuTbtPmmBb9Smtklr59EzidtGFt3RxT5aEoyF8ptk0kEd9ekU26WolaUje7rwNfbwy2robYdmqlklAlmPd/I/mRP8I6bHaW/YSU4ewd5qKZepQi1jiyghutDayZixyVf/X9fIGTBMme4sx0fcXZUfFFZTdrKJywlbg9UgbWFAJl5Pm7qYuNqoYtIA7uEn3kzDU9OVQdierbEifwq8tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:17 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:16 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/61] mmc: omap_hsmmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:51 +0800 Message-Id: <20230726040041.26267-11-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: d90d4c21-c888-4d6b-0b94-08db8d8cf5c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4OPzs28baHS6UGL5nLs0YguIXlTvr8xjlW0RwvZn3I3WFvOw7Qyn5JuTXrYgnAelA4ayzm001/PwbAEZqhy433Y2yDOt7RQKFpnTiCKmNkfGWpGbPIhY7n3YeolT2TnCcK+ARSZXXNhHPTisElxE2q78PVmaN1p1Z/HWZueb5v0ZhXHgUUM7sbWWeEBjNx8Xn3cHHn7EzhRE1awUMkjxAjkl1ynij0bWqzJZB6YpmhQ1qvYdyRIa/Ua2zyF1OOKPeH2UChb/Mv/GmvOY/qkJYXxKnK96qvybo04/do8rA3xpFh8F4zW5St5Dk+Yrrfwo7GbDeLe3fjdtBOZ/JdQ3hVSqoCZT+rRBk9+GDLaVXpvuvANWsrwiqQO2LtotcaLdLQRL79caYWzx/RTVP/pXdr5a7C1AYKzxtlaqopj+lSx3aUmnTkjgCEZo46REg4XoATXGtuCEL3zp0hY/Y4IRQIaLwdSqwhFUCjlaLk4KM0JHABXl+UVL+3I2jvD0nynRFoEEi/+W1zTINx54w1zvq7imXfMFl1B1riD8cpbpzAmMEiJvO4eujHNjmezKcipkUpaplvwV7C+JXKccs0TWcONesHHnga7Q8HOMTMnuEjOMbccDNhZr/9LF3XplIct5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(6486002)(52116002)(54906003)(66476007)(316002)(6916009)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ChxdbENK+5FBbwRaus+OhvQ3cYGz?= =?utf-8?q?CYPrYI9xSL01wTNaN8h7UwAyCYWi/qNYEFXQ6WEI2YboraKOmTNIxj5VBQrAc97O8?= =?utf-8?q?bqqVnCYxaL3z9mZCohkRb7+iUjIgRP/ZYhIwg2xkuTfkxEcXxQBD6eqyxV9gwNX76?= =?utf-8?q?lvJ8NGyFyOMKl0iwbiOwSknLDR12rZq1DHTzTHbuXonwEH5Oe0mm0/HFxHiratNyh?= =?utf-8?q?hiQ/S+KaYDLLnYy0o7rqQPr0pZgk2qcTMeUgDPAnpN9w21Wigs1WVA4CVjg1hFf9w?= =?utf-8?q?BsxcCe+cgWYHz53Mu0T7ZHnQ1tPaM7SgHPtT/2gDmtpEinWDcVONq5J5Hvtri1OSb?= =?utf-8?q?QUbxjGUpaT+aMQXyLba/kx+IJ08Oybk2/aEjMyZ8WPYP5o2SokyfBivp+IYx1Mc6F?= =?utf-8?q?vKD54XJs8dOpqzXCRYG3svko75Ae+/O5kDmwCVwegThRNKp0VvIBpPhs8PDNXvNVB?= =?utf-8?q?NBIQuUJhLXBJ3EOW8/fxpln2QO7t2Zlv2OWIPJC2HdP85GSW+hoUhDqE4QAJ2PBkk?= =?utf-8?q?xg5ZD0rppS2m1unhZbggUTjlp0G/MlDHO/0btvfiVgtwiRCfoBWQkFpyWxOB+i5/6?= =?utf-8?q?m1vfhHuMnVMaC431G221cBLgR0s84FgtE9gyHLRWoDGQ6qyE0w8EVN2kvxgOPPzV4?= =?utf-8?q?hD3V3ma9ijArW/8OA85Cv1zDkZ9r8wxaBYmDmNuX9q9K4krKUYZ3uPc2ffHgPu+Eb?= =?utf-8?q?7L2VAbgNJTu/6F9rLXfzHehBDgwLvxrQGzx7Gf3bq1louTMjd2fsQebkqbqgikPrQ?= =?utf-8?q?yrcsn7Jt5OluGBdMSObVDoMwMKu+jrxiQEMaTfpSZRc6jyvcY9+0Q8nSX5Vmeibin?= =?utf-8?q?ERC1syIb7Ko0RNvnSp1y0kDlQUgUKFTu5mE4gl7Vdomo1H+cDI1oV+kxeAVJGjMI1?= =?utf-8?q?W3vECssmk9xb9n9JWwlcZzxHYaXNZSmlLuAQFwKp/bAQmU8J4hW6lZcmdSHW/XPgC?= =?utf-8?q?UFkyvnomDo0aH19/5BSH2l9aLXK5C7+qW5DlFNPgWBWGmdpqd1UhOz3PEM1It04Oa?= =?utf-8?q?WtyQR/pETWs0J3o9rAci6xK4hCBOBQ2DjMVxts4MTtC3jq80KZljd4KT5p4KvUGCz?= =?utf-8?q?zYxgJjvoqd4VnXqkqyde6GkEcrt4Zh02zvtpfRh/oTPCaE45CGDU3dnvPCPmCZpnu?= =?utf-8?q?TVDGbZYinvFnjb79xLZpssjyrxVgwr/e7gjtILszbtIUB5IBAjmoeR8jvdVlxFzjY?= =?utf-8?q?WHPNUK3ZXzZeQs+S+nY/OdU6vm5Czh4lg5uXKn647h7YM0H0ZB/J0mce/lFDWsZ/m?= =?utf-8?q?zRrNnfUPVT5DwkOvSem1QZWHKaQwfpPZIVmuAq/g0mQXx5WKXk2yo1RsXudjpL/hV?= =?utf-8?q?0SByoSK00Os9J5pc2RqHzmCAUUfKFwJO/tGIncQ0XmF5uj9jUzIcW9Dox+6mpAfcz?= =?utf-8?q?4OJkbbJF8lmssNYkIBnvUc0z2eIUej07Ic69T5V+O7wy6nQDfmXqsaLVpHEmuV9hJ?= =?utf-8?q?Pic62IhJnw1JkXR++MV9I4ikNsq2FudYBaeXnNTjNbFRptQ6FYahDbFNcCO1psVNJ?= =?utf-8?q?5o2l83dMI2Fr?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d90d4c21-c888-4d6b-0b94-08db8d8cf5c8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:16.3255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jLXouBuCBTwR4mZrrJ5Of5m2rO2mU8Lmkwx5XB62PkQ201pEjqoVQU4sD+fdxbD6Pfkbe2/xme5tWIUUW7tMPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/omap_hsmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 93de00a06aba..e120aeb869b8 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1979,7 +1979,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) return ret; } -static int omap_hsmmc_remove(struct platform_device *pdev) +static void omap_hsmmc_remove(struct platform_device *pdev) { struct omap_hsmmc_host *host = platform_get_drvdata(pdev); @@ -1997,8 +1997,6 @@ static int omap_hsmmc_remove(struct platform_device *pdev) clk_disable_unprepare(host->dbclk); mmc_free_host(host->mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2123,7 +2121,7 @@ static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = { static struct platform_driver omap_hsmmc_driver = { .probe = omap_hsmmc_probe, - .remove = omap_hsmmc_remove, + .remove_new = omap_hsmmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS,