[V3] dt-bindings: pinctrl: pinctrl-single: add am625 compatible

Commit Message

Dhruva Gole Aug. 4, 2023, 5:07 a.m. UTC

Add the am625 compatible property to add support for the new
wakeup enable and status bits positions

Cc: Nishanth Menon <[e-mail]>
Cc: Vignesh Raghavendra <[e-mail]>
CC: Tony Lindgren <[e-mail]>
Acked-by: Conor Dooley <[e-mail]>
Signed-off-by: Dhruva Gole <[e-mail]>
---

Base: tag: next-20230731 + below "depends on" patch
Depends on: https://lore.kernel.org/linux-omap/[e-mail]/T/

Changelog:

* v2 -> v3:
keep order sorted, Suggested-by: Nishanth Menon <[e-mail]>
link to v2: https://lore.kernel.org/all/[e-mail]/

* v1 -> v2 changes:
rename to use am625 instead of am6
link to v1:
https://lore.kernel.org/all/[e-mail]/


 Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Nishanth Menon Aug. 4, 2023, 9:14 p.m. UTC | #1

On 10:37-20230804, Dhruva Gole wrote:
> Add the am625 compatible property to add support for the new
> wakeup enable and status bits positions
> 
> Cc: Nishanth Menon <[e-mail]>
> Cc: Vignesh Raghavendra <[e-mail]>
> CC: Tony Lindgren <[e-mail]>
> Acked-by: Conor Dooley <[e-mail]>
> Signed-off-by: Dhruva Gole <[e-mail]>
> ---

How about the driver changes to actually support this compatible?

Dhruva Gole Aug. 5, 2023, 5:14 a.m. UTC | #2

On Aug 04, 2023 at 16:14:32 -0500, Nishanth Menon wrote:
> On 10:37-20230804, Dhruva Gole wrote:
> > Add the am625 compatible property to add support for the new
> > wakeup enable and status bits positions
> > 
> > Cc: Nishanth Menon <[e-mail]>
> > Cc: Vignesh Raghavendra <[e-mail]>
> > CC: Tony Lindgren <[e-mail]>
> > Acked-by: Conor Dooley <[e-mail]>
> > Signed-off-by: Dhruva Gole <[e-mail]>
> > ---
> 
> How about the driver changes to actually support this compatible?

Wanted to post this patch before I posted the driver changes,
have posted them here now:

https://lore.kernel.org/all/[e-mail]

> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Nishanth Menon Aug. 5, 2023, 5:17 p.m. UTC | #3

On 10:44-20230805, Dhruva Gole wrote:
> On Aug 04, 2023 at 16:14:32 -0500, Nishanth Menon wrote:
> > On 10:37-20230804, Dhruva Gole wrote:
> > > Add the am625 compatible property to add support for the new
> > > wakeup enable and status bits positions
> > > 
> > > Cc: Nishanth Menon <[e-mail]>
> > > Cc: Vignesh Raghavendra <[e-mail]>
> > > CC: Tony Lindgren <[e-mail]>
> > > Acked-by: Conor Dooley <[e-mail]>
> > > Signed-off-by: Dhruva Gole <[e-mail]>
> > > ---
> > 
> > How about the driver changes to actually support this compatible?
> 
> Wanted to post this patch before I posted the driver changes,
> have posted them here now:
> 
> https://lore.kernel.org/all/[e-mail]
> 

Please dont patches piecemeal - it makes no sense to review without
context.

Please send future series organized as follows:
* binding
* driver updates
* if any dts updates are relevant - mark them as DONOTMERGE to let the
  driver maintainer know that the dts patches go via SoC tree - most
  maintainers know this, but it is better to be safe.

Tony Lindgren Aug. 8, 2023, 10:21 a.m. UTC | #4

* Dhruva Gole <[e-mail]> [230804 05:10]:
> Add the am625 compatible property to add support for the new
> wakeup enable and status bits positions

Looks good to me:

Reviewed-by: Tony Lindgren <[e-mail]>

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index b6b6bcd7074b..b0a10ab22b74 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -24,6 +24,7 @@  properties:
       - items:
           - enum:
               - ti,am437-padconf
+              - ti,am625-padconf
               - ti,dra7-padconf
               - ti,omap2420-padconf
               - ti,omap2430-padconf