diff mbox series

arm: omap1: remove duplicated 'select ARCH_OMAP'

Message ID 20240204125716.56756-1-masahiroy@kernel.org (mailing list archive)
State New, archived
Headers show
Series arm: omap1: remove duplicated 'select ARCH_OMAP' | expand

Commit Message

Masahiro Yamada Feb. 4, 2024, 12:57 p.m. UTC 
Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
added one more 'select ARCH_OMAP'.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/arm/mach-omap1/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Masahiro Yamada Feb. 4, 2024, 1:18 p.m. UTC | #1 
Just a nit.

The commit subject "arm:" should be capitalized to "ARM:"
because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?


On Sun, Feb 4, 2024 at 9:57 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
> added one more 'select ARCH_OMAP'.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  arch/arm/mach-omap1/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
> index cbf703f0d850..a643b71e30a3 100644
> --- a/arch/arm/mach-omap1/Kconfig
> +++ b/arch/arm/mach-omap1/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
>         depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
>         depends on CPU_LITTLE_ENDIAN
>         depends on ATAGS
> -       select ARCH_OMAP
>         select ARCH_HAS_HOLES_MEMORYMODEL
>         select ARCH_OMAP
>         select CLKSRC_MMIO
> --
> 2.40.1
>
Tony Lindgren Feb. 28, 2024, 7:28 a.m. UTC | #2 
* Masahiro Yamada <masahiroy@kernel.org> [240204 13:19]:
> Just a nit.
> 
> The commit subject "arm:" should be capitalized to "ARM:"
> because it is a convention for changes under arch/arm/.
> 
> Maybe, the maintainer can cater to it?

Thanks yes applying into omap-for-v6.9/omap1 with the prefix
changed.

Regards,

Tony
diff mbox series

Patch

diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
index cbf703f0d850..a643b71e30a3 100644
--- a/arch/arm/mach-omap1/Kconfig
+++ b/arch/arm/mach-omap1/Kconfig
@@ -4,7 +4,6 @@  menuconfig ARCH_OMAP1
 	depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
 	depends on CPU_LITTLE_ENDIAN
 	depends on ATAGS
-	select ARCH_OMAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_OMAP
 	select CLKSRC_MMIO