diff mbox series

[v2,24/24] mfd: sprd-sc27xx-spi: Constify struct regmap_bus

Message ID 20240704-mfd-const-regmap_config-v2-24-0c8785b1331d@gmail.com (mailing list archive)
State New
Headers show
Series mfd: Constify read-only regmap structs | expand

Commit Message

Javier Carrasco July 4, 2024, 5:23 p.m. UTC
`sprd_pmic_regmap` is not modified and can be declared as const to
move its data to a read-only section.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/mfd/sprd-sc27xx-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Baolin Wang July 5, 2024, 1:11 a.m. UTC | #1
On 2024/7/5 01:23, Javier Carrasco wrote:
> `sprd_pmic_regmap` is not modified and can be declared as const to
> move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   drivers/mfd/sprd-sc27xx-spi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 81e517cdfb27..7186e2108108 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -135,7 +135,7 @@ static int sprd_pmic_spi_read(void *context,
>   	return 0;
>   }
>   
> -static struct regmap_bus sprd_pmic_regmap = {
> +static const struct regmap_bus sprd_pmic_regmap = {
>   	.write = sprd_pmic_spi_write,
>   	.read = sprd_pmic_spi_read,
>   	.reg_format_endian_default = REGMAP_ENDIAN_NATIVE,
>
diff mbox series

Patch

diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
index 81e517cdfb27..7186e2108108 100644
--- a/drivers/mfd/sprd-sc27xx-spi.c
+++ b/drivers/mfd/sprd-sc27xx-spi.c
@@ -135,7 +135,7 @@  static int sprd_pmic_spi_read(void *context,
 	return 0;
 }
 
-static struct regmap_bus sprd_pmic_regmap = {
+static const struct regmap_bus sprd_pmic_regmap = {
 	.write = sprd_pmic_spi_write,
 	.read = sprd_pmic_spi_read,
 	.reg_format_endian_default = REGMAP_ENDIAN_NATIVE,