From patchwork Tue Apr 6 17:52:47 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guzman Lugo, Fernando" X-Patchwork-Id: 90820 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o36HqBLC001793 for ; Tue, 6 Apr 2010 17:52:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756104Ab0DFRwx (ORCPT ); Tue, 6 Apr 2010 13:52:53 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44670 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755868Ab0DFRwx convert rfc822-to-8bit (ORCPT ); Tue, 6 Apr 2010 13:52:53 -0400 Received: from dlep35.itg.ti.com ([157.170.170.118]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o36HqnCf021555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 6 Apr 2010 12:52:49 -0500 Received: from dlep26.itg.ti.com (localhost [127.0.0.1]) by dlep35.itg.ti.com (8.13.7/8.13.7) with ESMTP id o36Hqmts014584; Tue, 6 Apr 2010 12:52:48 -0500 (CDT) Received: from dlee73.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id o36Hqm8E008639; Tue, 6 Apr 2010 12:52:48 -0500 (CDT) Received: from dlee06.ent.ti.com ([157.170.170.11]) by dlee73.ent.ti.com ([157.170.170.88]) with mapi; Tue, 6 Apr 2010 12:52:48 -0500 From: "Guzman Lugo, Fernando" To: "linux-omap@vger.kernel.org" CC: Hiroshi DOYU , Ameya Palande , "felipe.contreras@nokia.com" Date: Tue, 6 Apr 2010 12:52:47 -0500 Subject: [PATCH 1/3] DSPBRIDGE: remove unused module parameters Thread-Topic: [PATCH 1/3] DSPBRIDGE: remove unused module parameters Thread-Index: AcrVsfe7YeKegAJOQLi8grzEAOai3Q== Message-ID: <496565EC904933469F292DDA3F1663E602CAF98C63@dlee06.ent.ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 06 Apr 2010 17:52:56 +0000 (UTC) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c index 5f01ab9..3d22f8c 100644 --- a/drivers/dsp/bridge/rmgr/drv_interface.c +++ b/drivers/dsp/bridge/rmgr/drv_interface.c @@ -88,8 +88,6 @@ static s32 driver_major; static char *base_img; char *iva_img; static s32 shm_size = 0x500000; /* 5 MB */ -static u32 phys_mempool_base; -static u32 phys_mempool_size; static int tc_wordswapon; /* Default value is always false */ #ifdef CONFIG_BRIDGE_RECOVERY #define REC_TIMEOUT 5000 /*recovery timeout in msecs */ @@ -133,13 +131,6 @@ MODULE_PARM_DESC(base_img, "DSP base image, default = NULL"); module_param(shm_size, int, 0); MODULE_PARM_DESC(shm_size, "shm size, default = 4 MB, minimum = 64 KB"); -module_param(phys_mempool_base, uint, 0); -MODULE_PARM_DESC(phys_mempool_base, - "Physical memory pool base passed to driver"); - -module_param(phys_mempool_size, uint, 0); -MODULE_PARM_DESC(phys_mempool_size, - "Physical memory pool size passed to driver"); module_param(tc_wordswapon, int, 0); MODULE_PARM_DESC(tc_wordswapon, "TC Word Swap Option. default = 0"); @@ -316,18 +307,9 @@ static int __devinit omap34_xx_bridge_probe(struct platform_device *pdev) } dev_dbg(bridge, "%s: requested shm_size = 0x%x\n", __func__, shm_size); - if (pdata->phys_mempool_base && pdata->phys_mempool_size) { - phys_mempool_base = pdata->phys_mempool_base; - phys_mempool_size = pdata->phys_mempool_size; - } - - dev_dbg(bridge, "%s: phys_mempool_base = 0x%x \n", __func__, - phys_mempool_base); - - dev_dbg(bridge, "%s: phys_mempool_size = 0x%x\n", __func__, - phys_mempool_base); - if ((phys_mempool_base > 0x0) && (phys_mempool_size > 0x0)) - mem_ext_phys_pool_init(phys_mempool_base, phys_mempool_size); + if ((pdata->phys_mempool_base > 0) && (pdata->phys_mempool_size > 0)) + mem_ext_phys_pool_init(pdata->phys_mempool_base, + pdata->phys_mempool_size); if (tc_wordswapon) { dev_dbg(bridge, "%s: TC Word Swap is enabled\n", __func__); reg_set_value(TCWORDSWAP, (u8 *) &tc_wordswapon,