From patchwork Sat Dec 19 15:17:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roel Kluin X-Patchwork-Id: 68931 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id nBJFNK6x012242 for ; Sat, 19 Dec 2009 15:23:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbZLSPWo (ORCPT ); Sat, 19 Dec 2009 10:22:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751308AbZLSPWo (ORCPT ); Sat, 19 Dec 2009 10:22:44 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:41872 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbZLSPWn (ORCPT ); Sat, 19 Dec 2009 10:22:43 -0500 Received: by ewy19 with SMTP id 19so2510372ewy.1 for ; Sat, 19 Dec 2009 07:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=y+rOyoHGxRIlV/4Wtl64X9BJc2CKDsp64ZWl6mhPDmg=; b=sLGHIwDEEqZ5AHM1G+yFYAy+vF9J1or7eN5U9N5wXaCuy9rac/o2NMR4SuDIAvx6kf QT97desdW50+bsBBfh7FAhWu5M82MLebJzbqIMvxiNut2AcKYpmlGvV89l2PcJXT5ySp tA4XuNAovY24H0XCXN/RYLM3tkZiRiH+r/82Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=IWubdOHWuNjkbvoRqOJVIVBYeeLqi1U3+iQsWePAL+BckNehkPQC/LGAFnJ62V8qGO icZ7/xN+yWA4G8qNHSs8uhA5uJCXBXdkId+/zW6g/HsoaBZ0NVXKG8Yv0QGT8r3kFqQ0 QFu63ob6i50rBultpf6jSWZeIQSWLyrQYIsrw= Received: by 10.213.102.65 with SMTP id f1mr12064971ebo.61.1261235730020; Sat, 19 Dec 2009 07:15:30 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 5sm13472808eyf.10.2009.12.19.07.15.28 (version=SSLv3 cipher=RC4-MD5); Sat, 19 Dec 2009 07:15:29 -0800 (PST) Message-ID: <4B2CEE94.3080800@gmail.com> Date: Sat, 19 Dec 2009 16:17:40 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: Tony Lindgren , "linux-omap@vger.kernel.org" , Andrew Morton , LKML Subject: [PATCH] OMAP: &&/|| confusion in iommu_put() Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c index c0ff1e3..463d638 100644 --- a/arch/arm/plat-omap/iommu.c +++ b/arch/arm/plat-omap/iommu.c @@ -827,7 +827,7 @@ EXPORT_SYMBOL_GPL(iommu_get); **/ void iommu_put(struct iommu *obj) { - if (!obj && IS_ERR(obj)) + if (!obj || IS_ERR(obj)) return; mutex_lock(&obj->iommu_lock);