From patchwork Fri Jan 14 08:48:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Weber X-Patchwork-Id: 477801 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0E8mCbS014700 for ; Fri, 14 Jan 2011 08:48:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753808Ab1ANIsL (ORCPT ); Fri, 14 Jan 2011 03:48:11 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:49289 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478Ab1ANIsL (ORCPT ); Fri, 14 Jan 2011 03:48:11 -0500 Received: from corscience.de (DSL01.212.114.252.242.ip-pool.NEFkom.net [212.114.252.242]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MhPvC-1PrVDm2Tf0-00McHv; Fri, 14 Jan 2011 09:48:08 +0100 Received: from [192.168.102.87] (unknown [192.168.102.87]) by corscience.de (Postfix) with ESMTP id E748B5212A; Fri, 14 Jan 2011 09:48:07 +0100 (CET) Message-ID: <4D300DC8.7000803@corscience.de> Date: Fri, 14 Jan 2011 09:48:08 +0100 From: Thomas Weber User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101220 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Daniel Morsing CC: Tony Lindgren , linux-omap@vger.kernel.org Subject: Re: [PATCH 0/3] omap3: devkit8000: misc fixes References: <1294963409-29891-1-git-send-email-daniel.morsing@gmail.com> In-Reply-To: <1294963409-29891-1-git-send-email-daniel.morsing@gmail.com> X-Enigmail-Version: 1.1.1 X-Provags-ID: V02:K0:E0i4mjpJCg16mmxej/XKFVdNU8+OJOz3dY8MJ5O772V COm3JN4G6pAuzZwOvE3nzcvSGT+DRn6IBLhFFhykBmhn8Y78Xt nhouoTJ7kGCPyPhv30EvH+6KVwYfRXYN0EAojudAVZaFb0+udW GHFG6UhHSwZ7ahND5nnmbJ4tZrMgFRPKuLBuq5XnnyuSFEOHoN TXVekGf/vSOr4et9oCx9w== Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 14 Jan 2011 08:48:13 +0000 (UTC) diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c index 8dc7a24..54f1f7f 100644 --- a/arch/arm/mach-omap2/board-devkit8000.c +++ b/arch/arm/mach-omap2/board-devkit8000.c @@ -114,9 +114,6 @@ static struct omap2_hsmmc_info mmc[] = { static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev) { - twl_i2c_write_u8(TWL4030_MODULE_GPIO, 0x80, REG_GPIODATADIR1); - twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0); - if (gpio_is_valid(dssdev->reset_gpio)) gpio_set_value_cansleep(dssdev->reset_gpio, 1); return 0; @@ -245,8 +242,8 @@ static int devkit8000_twl_gpio_setup(struct device *dev, /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */ gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1; - /* gpio + 1 is "LCD_PWREN" (out, active high) */ - devkit8000_lcd_device.reset_gpio = gpio + 1; + /* TWL4030_GPIO_MAX + 0 is "LCD_PWREN" (out, active high) */ + devkit8000_lcd_device.reset_gpio = gpio + TWL4030_GPIO_MAX + 0; gpio_request(devkit8000_lcd_device.reset_gpio, "LCD_PWREN"); /* Disable until needed */ gpio_direction_output(devkit8000_lcd_device.reset_gpio, 0);