diff mbox

[V2] Add missing modules aliases to get sound working on omap devices

Message ID 4FFECC40.5020502@free.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Guillaume GARDET July 12, 2012, 1:08 p.m. UTC
This patch add missing modules aliases to get sound working on omap devices.

Tested on Beagleboard xM rev. B.

This patch is against 3.5-rc6 vanilla.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>

Comments

Mark Brown July 13, 2012, 10:09 a.m. UTC | #1
On Thu, Jul 12, 2012 at 03:08:16PM +0200, Guillaume Gardet wrote:
> This patch add missing modules aliases to get sound working on omap devices.
> 
> Tested on Beagleboard xM rev. B.
> 
> This patch is against 3.5-rc6 vanilla.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>
> 
> 

> From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Date: Tue, 10 Jul 2012 13:47:16 +0200

Please resend in the format from SubmittingPatches rather than as an
attachment.
Mark Brown July 26, 2012, 10 p.m. UTC | #2
On Thu, Jul 12, 2012 at 03:08:16PM +0200, Guillaume Gardet wrote:
> This patch add missing modules aliases to get sound working on omap devices.

So, after a bunch of hand editing I applied this.  As I *repeatedly*
requested you should send patches in the format covered in
SubmittingPatches, the main reason it took me so long to get round to
applying this is that I had to strip things like this:

> From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Date: Tue, 10 Jul 2012 13:47:16 +0200
> Subject: [PATCH] Add missing modules aliases to fix audio on omap devices

out of the commit message, plus the fact that since you hadn't used an
appropriate subject line for the subsystem your patch didn't turn up
when I searched my mail for patches to be handled.
diff mbox

Patch

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices

---
 sound/soc/omap/omap-mcbsp.c |    1 +
 sound/soc/omap/omap-pcm.c   |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 1046083..acdd3ef 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -820,3 +820,4 @@  module_platform_driver(asoc_mcbsp_driver);
 MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
 MODULE_DESCRIPTION("OMAP I2S SoC Interface");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-mcbsp");
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 5a649da..f0feb06 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -441,3 +441,4 @@  module_platform_driver(omap_pcm_driver);
 MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
 MODULE_DESCRIPTION("OMAP PCM DMA module");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-pcm-audio");
-- 
1.7.7