| Message ID | 5130FD73.9030601@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 1, 2013 at 8:11 PM, Randy Dunlap <rdunlap@infradead.org> wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix kernel-doc warnings in hsi files: > > Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'e_handler' description in 'hsi_client' > Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'pclaimed' description in 'hsi_client' > Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'nb' description in 'hsi_client' > Warning(drivers/hsi/hsi.c:434): No description found for parameter 'handler' > Warning(drivers/hsi/hsi.c:434): Excess function parameter 'cb' description in 'hsi_register_port_event' > > Don't document "private:" fields with kernel-doc notation. > If you want to leave them fully documented, that's OK, but > then don't mark them as "private:". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Carlos Chinea <carlos.chinea@nokia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-kernel@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Acked-by: Nishanth Menon <nm@ti.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> HSI is basically orphaned FTM. Andrew can you pick this into your orphanage? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/03/13 18:56, Linus Walleij wrote: > On Fri, Mar 1, 2013 at 8:11 PM, Randy Dunlap <rdunlap@infradead.org> wrote: > >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fix kernel-doc warnings in hsi files: >> >> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'e_handler' description in 'hsi_client' >> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'pclaimed' description in 'hsi_client' >> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'nb' description in 'hsi_client' >> Warning(drivers/hsi/hsi.c:434): No description found for parameter 'handler' >> Warning(drivers/hsi/hsi.c:434): Excess function parameter 'cb' description in 'hsi_register_port_event' >> >> Don't document "private:" fields with kernel-doc notation. >> If you want to leave them fully documented, that's OK, but >> then don't mark them as "private:". >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Carlos Chinea <carlos.chinea@nokia.com> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-omap@vger.kernel.org >> Acked-by: Nishanth Menon <nm@ti.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > HSI is basically orphaned FTM. > > Andrew can you pick this into your orphanage? Linus (Torvalds) already merged it. Thanks.
--- lnx-38.orig/drivers/hsi/hsi.c +++ lnx-38/drivers/hsi/hsi.c @@ -420,7 +420,7 @@ static int hsi_event_notifier_call(struc /** * hsi_register_port_event - Register a client to receive port events * @cl: HSI client that wants to receive port events - * @cb: Event handler callback + * @handler: Event handler callback * * Clients should register a callback to be able to receive * events from the ports. Registration should happen after --- lnx-38.orig/include/linux/hsi/hsi.h +++ lnx-38/include/linux/hsi/hsi.h @@ -121,9 +121,9 @@ static inline int hsi_register_board_inf * @device: Driver model representation of the device * @tx_cfg: HSI TX configuration * @rx_cfg: HSI RX configuration - * @e_handler: Callback for handling port events (RX Wake High/Low) - * @pclaimed: Keeps tracks if the clients claimed its associated HSI port - * @nb: Notifier block for port events + * e_handler: Callback for handling port events (RX Wake High/Low) + * pclaimed: Keeps tracks if the clients claimed its associated HSI port + * nb: Notifier block for port events */ struct hsi_client { struct device device;