From patchwork Thu Mar 14 07:45:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 2268111 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 922BBDFB79 for ; Thu, 14 Mar 2013 07:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281Ab3CNHnu (ORCPT ); Thu, 14 Mar 2013 03:43:50 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:43805 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220Ab3CNHnu (ORCPT ); Thu, 14 Mar 2013 03:43:50 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r2E7hTsS024137; Thu, 14 Mar 2013 02:43:30 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2E7hROC019203; Thu, 14 Mar 2013 13:13:28 +0530 (IST) Received: from dbdp33.itg.ti.com (172.24.170.252) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Thu, 14 Mar 2013 13:13:27 +0530 Received: from [172.24.136.207] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp33.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2E7hMcl022977; Thu, 14 Mar 2013 13:13:23 +0530 Message-ID: <5141800A.2000307@ti.com> Date: Thu, 14 Mar 2013 13:15:14 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Mark Rutland CC: Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , Russell King Subject: Re: [PATCH] ARM: smp: Allow real broadcast device selection instead of always dummy References: <1363165608-13739-1-git-send-email-santosh.shilimkar@ti.com> <514046B6.9020005@ti.com> <20130313101641.GA13483@e106331-lin.cambridge.arm.com> <514061D1.20603@ti.com> <20130313122550.GD13483@e106331-lin.cambridge.arm.com> <51409EC3.5050905@ti.com> <20130313161811.GF13483@e106331-lin.cambridge.arm.com> In-Reply-To: <20130313161811.GF13483@e106331-lin.cambridge.arm.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wednesday 13 March 2013 09:48 PM, Mark Rutland wrote: > On Wed, Mar 13, 2013 at 03:44:03PM +0000, Santosh Shilimkar wrote: >> On Wednesday 13 March 2013 05:55 PM, Mark Rutland wrote: >>> On Wed, Mar 13, 2013 at 11:24:01AM +0000, Santosh Shilimkar wrote: >>>> On Wednesday 13 March 2013 03:46 PM, Mark Rutland wrote: >>>>> Hi Santosh, >> >> [..] >> >>>>> >>>>> Is the problem that the dummy timer is being registered as the broadcast >>>>> source, or that it is selected as a local timer in preference of real timers? >>>>> >>>> Dummy timer is preferred over real broadcast timer. >>> >>> Ok. > > [...] > >>> I do agree it'd be worth lowering the dummy timer's rating to ensure it doesn't >>> override a real timer elsewhere. >>> >> Yep. Can I add you acked-by tag then for $subject patch ? >> Would be good to get this one merged as well. > > Sure. Though could you reword the commit message? The patch solves the more > general issue of a dummy being preferred over real hardware even outside of > choosing the broadcast device. > > Acked-by: Mark Rutland Thanks. For record, patch is in end of the email which I plan to put into patch system. Regards, Santosh From 57c501bcdc88c7ff26a5c63956be07e94a5083c5 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Wed, 13 Mar 2013 12:33:16 +0530 Subject: [PATCH 1/2] ARM: smp: Avoid dummy clockevent being preferred over real hardware clock-event With recent arm broadcast time clean-up from Mark Rutland, the dummy broadcast device is always registered with timer subsystem. And since the rating of the dummy clock event is very high, it may be preferred over a real clock event. This is a change in behavior from past and not an intended one. So reduce the rating of the dummy clockevent so that real clockevent device is selected when available. Acked-by: Mark Rutland Signed-off-by: Santosh Shilimkar Acked-by: Thomas Gleixner --- arch/arm/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 31644f1..79078ed 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -480,7 +480,7 @@ static void __cpuinit broadcast_timer_setup(struct clock_event_device *evt) evt->features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_DUMMY; - evt->rating = 400; + evt->rating = 100; evt->mult = 1; evt->set_mode = broadcast_timer_set_mode;