From patchwork Wed Jun 26 13:22:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajendra Nayak X-Patchwork-Id: 2784501 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 28D1F9F3A0 for ; Wed, 26 Jun 2013 13:23:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E950A20497 for ; Wed, 26 Jun 2013 13:23:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FF8720108 for ; Wed, 26 Jun 2013 13:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374Ab3FZNXm (ORCPT ); Wed, 26 Jun 2013 09:23:42 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:58770 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276Ab3FZNXm (ORCPT ); Wed, 26 Jun 2013 09:23:42 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r5QDN3gN002619; Wed, 26 Jun 2013 08:23:03 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r5QDN2ed004427; Wed, 26 Jun 2013 08:23:03 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Wed, 26 Jun 2013 08:23:02 -0500 Received: from [172.24.145.77] (ula0131687-172024145077.apr.dhcp.ti.com [172.24.145.77]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r5QDN0eM000852; Wed, 26 Jun 2013 08:23:00 -0500 Message-ID: <51CAEB33.5010101@ti.com> Date: Wed, 26 Jun 2013 18:52:59 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: "Hiremath, Vaibhav" CC: Kevin Hilman , "Rini, Tom" , Paul Walmsley , "linux-omap@vger.kernel.org" , "Balbi, Felipe" , "linux-arm-kernel@lists.infradead.org" Subject: Re: OMAP baseline test results for v3.10-rc6 References: <20130625160243.GE22312@arwen.pp.htv.fi> <51C9F0A8.1050607@ti.com> <87fvw6t136.fsf@linaro.org> <79CD15C6BA57404B839C016229A409A83ECC952D@DBDE04.ent.ti.com> In-Reply-To: <79CD15C6BA57404B839C016229A409A83ECC952D@DBDE04.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP >> >> Just to confirm, my problems with mainline were with appended DTB also. >> Separate DTB and zImage work fine (at least using u-boot v2013.04.) >> >> That being said, appended DTB should still work, so there's a bug >> hiding >> someplace that needs to be found fixed. >> >> Can you guys update your tests to test appended DTB also? >> > > What is missing here is, > > CONFIG_ARM_APPENDED_DTB = y > CONFIG_ARM_ATAG_DTB_COMPAT = y > > > And for the code which is required in case of appended DTB, please refer to the code > "arch/arm/boot/compressed/head.S" > > > Please __NOTE__ that these options are not enabled in default omap2plus_defconfig. Paul/Kevin, Apart from confirming if you are manually enabling these options, can you also give some details on how you append the dtb to the kernel image? Most of us use an out-of-tree patch from Grant to do this, which I have shared below [2] Even without the patch with the below commands [1] to append the dtb, it still works, so it would be good to know what steps you follow to append the dtb to the kernel image. regards, Rajendra [1] cat arch/arm/boot/zImage arch/arm/boot/dts/am335x-bone.dtb > zImage mkimage -A arm -O linux -T kernel -C none -a 0x80008000 -e 0x80008000 -n "Linux" -d zImage uImage [2] From: Grant Likely Date: Tue, 24 Apr 2012 16:19:29 +0530 Subject: Makefile: Build a uImage with dtb already appended Do not commit to mainline; this is a useful hack only for now. Signed-off-by: Grant Likely --- arch/arm/Makefile | 2 ++ arch/arm/boot/Makefile | 7 +++++++ 2 files changed, 9 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/arch/arm/Makefile =================================================================== --- linux-2.6.orig/arch/arm/Makefile 2013-04-24 12:25:22.547990009 +0530 +++ linux-2.6/arch/arm/Makefile 2013-04-26 14:30:57.143150733 +0530 @@ -295,6 +295,8 @@ %.dtb: scripts $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ +uImage.%: uImage + $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@ dtbs: scripts $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) dtbs Index: linux-2.6/arch/arm/boot/Makefile =================================================================== --- linux-2.6.orig/arch/arm/boot/Makefile 2013-04-24 12:25:22.547990009 +0530 +++ linux-2.6/arch/arm/boot/Makefile 2013-04-26 14:30:57.151150508 +0530 @@ -55,6 +55,9 @@ $(call if_changed,objcopy) @$(kecho) ' Kernel: $@ is ready' +$(obj)/zImage-dtb.%: $(obj)/dts/%.dtb $(obj)/zImage + cat $(obj)/zImage $< > $@ + endif ifneq ($(LOADADDR),) @@ -80,6 +83,10 @@ $(call if_changed,uimage) @$(kecho) ' Image $@ is ready' +$(obj)/uImage.%: $(obj)/zImage-dtb.% FORCE + $(call if_changed,uimage) + @echo ' Image $@ is ready' + $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE $(Q)$(MAKE) $(build)=$(obj)/bootp $@ @: