From patchwork Wed Oct 30 20:10:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 3116421 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DA043BF924 for ; Wed, 30 Oct 2013 20:10:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0B24F2040F for ; Wed, 30 Oct 2013 20:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB70E203B5 for ; Wed, 30 Oct 2013 20:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553Ab3J3UKk (ORCPT ); Wed, 30 Oct 2013 16:10:40 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:57328 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966Ab3J3UKk (ORCPT ); Wed, 30 Oct 2013 16:10:40 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r9UKA3Iu027485; Wed, 30 Oct 2013 15:10:03 -0500 Received: from DFLE73.ent.ti.com ([128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r9UKA2dU030409; Wed, 30 Oct 2013 15:10:03 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Wed, 30 Oct 2013 15:10:02 -0500 Received: from [128.247.91.123] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r9UKA18M016603; Wed, 30 Oct 2013 15:10:01 -0500 Message-ID: <52716799.6040002@ti.com> Date: Wed, 30 Oct 2013 15:10:01 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Tero Kristo , , , , , , CC: , Subject: Re: [PATCHv9 00/43] ARM: TI SoC clock DT conversion References: <1382716658-6964-1-git-send-email-t-kristo@ti.com> <526FDFF4.9030806@ti.com> <5270C1F3.6000409@ti.com> <52711F12.1090008@ti.com> In-Reply-To: <52711F12.1090008@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 10/30/2013 10:00 AM, Nishanth Menon wrote: > On 10/30/2013 03:23 AM, Tero Kristo wrote: >> On 10/29/2013 06:19 PM, Nishanth Menon wrote: >>> On 10/25/2013 10:56 AM, Tero Kristo wrote: >>> >>>> Testing done: >>>> - omap3-beagle: boot + suspend/resume (ret + off) >>>> - omap4-panda-es: boot + suspend/resume >>>> - omap5-uevm: boot >>>> - dra7-evm: boot >>>> - am335x-bone: boot >>>> >>>> Test branches available: >>>> >>>> tree: https://github.com/t-kristo/linux-pm.git >>> >>> >>>> Fully functioning test branch: 3.12-rc6-dt-clks-v9 >>>> >>> ^^ I tested this branch (boot testing): >>> Beagle-XM: http://pastebin.com/50A1qtFq (crashes + clkdm issues, dpll5 >>> failed to transition) >> >> I just sent you a private email with a patch to try out, should fix the >> boot crash at least hopefully. Basically I forgot to convert one part of >> the kernel to the new regmap stuff for omap36xx. > > it does bootup yes. >> >> clkdm issues are caused by wrong data in omap_hwmod_3xxx_data.c, USB >> nodes are listing l3_init_clkdm for them, but this only exists on >> omap4+. Seems like some copy paste bug introduced by someone. >> >> dpll5 part I am not too sure, can you check if the same happens with >> non-dt boot? > > no-dt: http://pastebin.com/bYP9fTzH > dt: http://pastebin.com/xHup4L9Y > > dpll5 warning seems to be only in dt-boot? > Tracked this down: you were missing the following - looks like the conversion script might be missing converting the flags clock data over to dts? diff --git a/arch/arm/boot/dts/omap36xx-am35xx-omap3430es2plus-clocks.dtsi b/arch/arm/boot/dts/omap36xx-am35xx-omap3430es2plus-clocks.dtsi index 7e37e3e..c9b77c8 100644 --- a/arch/arm/boot/dts/omap36xx-am35xx-omap3430es2plus-clocks.dtsi +++ b/arch/arm/boot/dts/omap36xx-am35xx-omap3430es2plus-clocks.dtsi @@ -30,6 +30,7 @@ compatible = "ti,omap3-dpll-clock"; clocks = <&sys_ck>, <&sys_ck>; reg = <0x0d04>, <0x0d24>, <0x0d34>, <0x0d4c>; + ti,low-power-stop; }; dpll5_m2_ck: dpll5_m2_ck {