From patchwork Wed Feb 17 07:31:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Dimitrov X-Patchwork-Id: 8335121 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1AAA99F2F0 for ; Wed, 17 Feb 2016 07:31:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2D5F7202F2 for ; Wed, 17 Feb 2016 07:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FE01202EB for ; Wed, 17 Feb 2016 07:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756671AbcBQHbg (ORCPT ); Wed, 17 Feb 2016 02:31:36 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:33278 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756450AbcBQHbf (ORCPT ); Wed, 17 Feb 2016 02:31:35 -0500 Received: by mail-wm0-f48.google.com with SMTP id g62so224268363wme.0; Tue, 16 Feb 2016 23:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=B9nwC0MORWL+XZkGKAlNLsNeullo9aWbKRMu3s9ggb0=; b=g4V4oV5BW3xbFrKyd4kAfJcBKdfQHgIhasbV2CNhjMZ8GGlK+18UEvQZ8z66aj17nX 4UJGPBiwFPQOItVBhUsVLdT8t0orzVDjJ8LIFhhvE3OqTZJ8pPdnvX+N+nb09juJSJUZ ubXfyIn/RLUGhtMH1BFOax9MHc+uYhtjPJkKikLSEu2O4YqGXx5JoK74C7fdQwDIhpuv TKsQLhvDtM3f1MEM0uvUPi5siCRCDzVGDavTz87mFSaFNL24cFwEGzEkmJPa/Gouc3HZ KWOJwubUdaEuLs0yYzf1HC2C4aceZvUZk3Y0siK0/tkwpMBkFbNa0kvKqBzbrnNuaZ0j rpuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=B9nwC0MORWL+XZkGKAlNLsNeullo9aWbKRMu3s9ggb0=; b=C55/mFh5zUeRgpB6yHOd8yEoE/uoskTWPYFfKKklFidMTxElH4fQ8qr/3I9gtCkJo+ xiXPGEpRRgpZJDhO9p5cNW03mDR0johJcrLLWqYEiv5ZByiXsx7Xp8+Ij7KK5/MKetoA +1zrkmEHb9Df0lEn7FMw2G28/H3vCuhRt8V6QqWQLBdWCTrLfQ+/hNoenpoLk4e6d+lQ kuaTqbb1p8jgbt6CABYNwfPiMzTqeCsqWHxLy0vYkqndZdkpR6ulpgfyZbpqdT1vZtRp gGMZr1DpCaeZAjUb8ziMsY6v2hJk9SwE6wm2DQBolIoSQSM3DYrnMYv9f4HqlqPOqfEL 4tfQ== X-Gm-Message-State: AG10YOQt1Q5WqF/pQwAHJl8wwQuwgMzKgXH8zysIfy2dCuOFSZPi4MnsMbh89d8OWLtXoA== X-Received: by 10.194.60.200 with SMTP id j8mr75808wjr.124.1455694294233; Tue, 16 Feb 2016 23:31:34 -0800 (PST) Received: from [192.168.1.10] ([46.249.74.23]) by smtp.googlemail.com with ESMTPSA id 73sm24061140wmy.22.2016.02.16.23.31.33 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 16 Feb 2016 23:31:33 -0800 (PST) Subject: Re: [PATCH] ARM: omapfb: Add early framebuffer memory allocator To: Tomi Valkeinen , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <52A062A0.3070005@ti.com> <1388013159-3036-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <201601011301.27415@pali> <568A5970.2000201@ti.com> <568A6DD1.5050700@gmail.com> <5693F5B7.8040608@ti.com> <56BEDA57.4030300@gmail.com> <56C32966.9020105@ti.com> Cc: tony@atomide.com, linux@arm.linux.org.uk, pavel@ucw.cz, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Ivaylo Dimitrov From: Ivaylo Dimitrov Message-ID: <56C421D3.5080101@gmail.com> Date: Wed, 17 Feb 2016 09:31:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56C32966.9020105@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On 16.02.2016 15:51, Tomi Valkeinen wrote: > > Does it work for you? I haven't used DT reserved-memory, do you have an > example .dts change? > Yes, it does work, I tested it on n900: > Now, having to support DT bindings is not any better than supporting > cmdline options. But with a quick read of reserved-memory.txt I like the > idea. However we should have "reserved memory for display", not for > omapfb, so that the same reserved area could be used by omapdrm too. Sounds reasonable and I don't really care how it is to be called or who does the actual reservation, as long as there is some reserved memory we can use for omapfb :) Keep in mind that the changes I did were just a quick-n-dirty hack to see if it will work and if you will accept something like that. A better approach is maybe to move RESERVEDMEM_OF_DECLARE() and co to display.c and pass base and size to whoever needs them (be it omapfb or omapdrm). Also, compatible could be called "ti,dss-memsize" or the like, but those are cosmetics IMO. > > Another thing, with v4.5, omapfb has moved into maintenance mode. I > don't want to merge new features there. Are you planning to move to > omapdrm, and if not, why? I'd rather see all this done for omapdrm only. I don't see a reason to not merge a small change like that in omapfb if there is reserved display memory used by omapdrm, but still, I am not the maintainer. Pali already explained the situation with PVR driver we use to boot maemo UI. Honestly, I have no idea what it takes to move from omapfb to omapdrm. Any hints? Ivo --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 1e94237..863d547 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -59,6 +59,18 @@ reg = <0x80000000 0x10000000>; /* 256 MB */ }; + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + omapfb_reserved: omapfb { + size = <0x700000>; + alignment = <0x100000>; + compatible = "ti,omapfb-memsize"; + }; + }; + gpio_keys { compatible = "gpio-keys"; @@ -1083,6 +1095,8 @@ vdds_sdi-supply = <&vaux1>; + memory-region = <&omapfb_reserved>; + ports { #address-cells = <1>; #size-cells = <0>;