From patchwork Sun Aug 16 21:30:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 41897 X-Patchwork-Delegate: me@felipebalbi.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7GLUUOm018517 for ; Sun, 16 Aug 2009 21:30:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbZHPVa1 (ORCPT ); Sun, 16 Aug 2009 17:30:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753651AbZHPVa1 (ORCPT ); Sun, 16 Aug 2009 17:30:27 -0400 Received: from mail-qy0-f196.google.com ([209.85.221.196]:37263 "EHLO mail-qy0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbZHPVa0 (ORCPT ); Sun, 16 Aug 2009 17:30:26 -0400 Received: by qyk34 with SMTP id 34so1911944qyk.33 for ; Sun, 16 Aug 2009 14:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=EXgCHTUU+VA7Ft8OqIUxJ9sLdaMHmZhyIwLnx0gEIAw=; b=w9ZL6cR+GNVPm1LJDviMc032YOVlbqUeB7qIZi+cMpiFbW9rvy92f+VQBl0MZgEcB2 nler711COQD/8PPQWI7UBjOJOTq4ymH/CT21d0xWvqlg32fweX9fxiEnj0vbFWU+/RRd ER/ZFvfNez32Z/zpdngaTCTrONAKPK3G9IRKU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=IQEtbU3FpTTNT+PdCZel4cPG4NPRFQJIYP/r9aSKAWDkeYuyoIeD4U0tIXUrQ4sSjd dvsbjW2yQ2/6u8+4rZKHE3PBc2kkpHh7YBq6a3hXI9hcdFl+9DamIZ5RTXlDz+KlnANg 9dTqnAJEPpQXM2yhtZMF8fcxZ/Pe7qBvXMhdo= MIME-Version: 1.0 Received: by 10.229.2.42 with SMTP id 42mr1702700qch.101.1250458227216; Sun, 16 Aug 2009 14:30:27 -0700 (PDT) Date: Sun, 16 Aug 2009 14:30:27 -0700 Message-ID: <5e088bd90908161430ka6c04f5m1cbf5e0df949f83@mail.gmail.com> Subject: ARM: OMAP3: Overo: Fix EHCI initialization From: Steve Sakoman To: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Overo uses port 2, not port 1. Use OVERO_GPIO_USBH_NRESET rather than hard coded value Note: this alone will not give functional EHCI. Also required is: [PATCH 4/9] ehci: fix phy_reset init in ehci probe from Ajay Kumar Gupta Signed-off-by: Steve Sakoman --- arch/arm/mach-omap2/board-overo.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index a9d7c2e..a220a54 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -394,7 +394,8 @@ static void __init overo_init(void) omap_serial_init(&overo_uart_config); overo_flash_init(); usb_musb_init(); - usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, false, true, 183, -EINVAL); + usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, false, true, + -EINVAL, OVERO_GPIO_USBH_NRESET); overo_ads7846_init(); overo_init_smsc911x(); @@ -437,14 +438,6 @@ static void __init overo_init(void) else printk(KERN_ERR "could not obtain gpio for " "OVERO_GPIO_USBH_CPEN\n"); - - if ((gpio_request(OVERO_GPIO_USBH_NRESET, - "OVERO_GPIO_USBH_NRESET") == 0) && - (gpio_direction_output(OVERO_GPIO_USBH_NRESET, 1) == 0)) - gpio_export(OVERO_GPIO_USBH_NRESET, 0); - else - printk(KERN_ERR "could not obtain gpio for " - "OVERO_GPIO_USBH_NRESET\n"); } static void __init overo_map_io(void)