diff mbox series

[RFC,4/6] ARM: DTS: omap4-l4-abe: Add McASP configuration

Message ID 6a4f04d5f977344b168d34029da4402cf37d8f68.1693918214.git.hns@goldelico.com (mailing list archive)
State New, archived
Headers show
Series tentative additions to fix ABE/AESS device tree entries for OMAP4&5 | expand

Commit Message

H. Nikolaus Schaller Sept. 5, 2023, 12:50 p.m. UTC 
From: Peter Ujfalusi <peter.ujfalusi@gmail.com>

OMAP4 has a single McASP instance with single serializer and locked for DIT
mode.
To be able to enable the support the following fixes needed:
- Add the DAT port ranges to the target module's ranges
- SIDLE mode must be disabled as it is not working with McASP
 most likely module integration issue with McASP

We can already fill in the op-mode and serial-dir  for McASP as it only
supports this configuration, but keep the module disabled as there is no
known device available where it is used.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
---
 arch/arm/boot/dts/ti/omap/omap4-l4-abe.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tony Lindgren Sept. 7, 2023, 5:35 a.m. UTC | #1 
* H. Nikolaus Schaller <hns@goldelico.com> [230905 15:58]:
> From: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> 
> OMAP4 has a single McASP instance with single serializer and locked for DIT
> mode.
> To be able to enable the support the following fixes needed:
> - Add the DAT port ranges to the target module's ranges

I think the above has been already done?

> - SIDLE mode must be disabled as it is not working with McASP
>  most likely module integration issue with McASP

Best to keep the dts entry as is and add quirk handling to ti-sysc driver
instead based on mcasp revision register detection. The dts is meant to
describe hardware and the register values exist.. But looking at ti-sysc
we already have mcasp tagged with SYSC_QUIRK_SWSUP_SIDLE.

If this patch is still needed, maybe check the revision register value and
mask in case there are multiple revisions, that's this line in ti-sysc:

SYSC_QUIRK("mcasp", 0, 0, 0x4, -ENODEV, 0x44306302, 0xffffffff,
           SYSC_QUIRK_SWSUP_SIDLE),

Regards,

Tony
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4-abe.dtsi b/arch/arm/boot/dts/ti/omap/omap4-l4-abe.dtsi
index 7ae8b620515c5..a8d66240d17d5 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-l4-abe.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap4-l4-abe.dtsi
@@ -192,8 +192,7 @@  target-module@28000 {			/* 0x40128000, ap 8 08.0 */
 			      <0x28004 0x4>;
 			reg-names = "rev", "sysc";
 			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
-					<SYSC_IDLE_NO>,
-					<SYSC_IDLE_SMART>;
+					<SYSC_IDLE_NO>;
 			/* Domains (V, P, C): iva, abe_pwrdm, abe_clkdm */
 			clocks = <&abe_clkctrl OMAP4_MCASP_CLKCTRL 0>;
 			clock-names = "fck";